Add more detail to error messages #94820
Conversation
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hixie
force-pushed
the
uname
branch
2 times, most recently
from
52c6389
to
fa50932
Compare
|
Gold has detected about 1 new digest(s) on patchset 1. |
|
cc @christopherfujino for review let me know if you think this is worth testing. my bias would be to not test this since it's just diagnostics changes and the precise text we output doesn't matter much except for testing purposes. |
I had a flake where the uname logic failed: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828555640002344561/+/u/run_test.dart_for_framework_tests_shard_and_subshard_widgets/test_stdout ...so this is adding more logging to try to understand this flake better next time.
| 'Error trying to run chmod on ${entity.absolute.path}' | ||
| '\nstdout: ${result.stdout}' | ||
| '\nstderr: ${result.stderr}', | ||
| 'Error trying to run "chmod $mode ${entity.path}":\n' |
There was a problem hiding this comment.
why not absolute path?
There was a problem hiding this comment.
I just figured it would be less confusing if the error message exactly matched the actual call we were making. I don't feel strongly about it though if you would rather we keep it absolute.
|
test-exempt: improves logging for existing tests |
I had a flake where the uname logic failed:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8828555640002344561/+/u/run_test.dart_for_framework_tests_shard_and_subshard_widgets/test_stdout
...so this is adding more logging to try to understand this flake better next time.