Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with samples #95044

Merged
merged 1 commit into from Dec 13, 2021
Merged

Fix some issues with samples #95044

merged 1 commit into from Dec 13, 2021

Conversation

gspencergoog
Copy link
Contributor

Description

This fixes various problems with some API examples. There were several places where people had used {@tool sample} when they meant {@tool dartpad}, and some issues with still using templates, which shouldn't be used except on Engine code at this point (and soon not there either).

Related Issues

Tests

  • Added tests for the two examples I extracted.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Dec 10, 2021
Piinks
Piinks approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

@fluttergithubbot fluttergithubbot merged commit bbc21fe into flutter:master Dec 13, 2021
@TahaTesser TahaTesser mentioned this pull request Feb 4, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Samples are no longer visible in API docs
3 participants
@gspencergoog @fluttergithubbot @Piinks