Correct the TabBarView swipe selection change animation #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (_previousIndex < _index) | ||
| progress = (_performance.progress - 0.5) * 2.0; | ||
| else | ||
| progress = 1.0 - _performance.progress * 2.0; |
There was a problem hiding this comment.
does all this work well when maxIndex == 0?
There was a problem hiding this comment.
I think you're right. I added some asserts to verify that two or more tab labels or views are specified, since that's what's supported now. Filed an issue for the general case:
#970
|
not sure I fully follow this logic, but LGTM. |
The TabBarSelection change animation needs to start where the fling's drag gesture ended rather than from zero. The intial vlaue of progress for the TabBarSelection's performance is now converted from the range used during an interactive drag, to the range used when animating from the previously selected tab to the new one. TabBarSelection now requires a maxIndex parameter.
HansMuller
force-pushed
the
fix_tab_swipe_animation
branch
from
ab8134c
to
65dca5b
Compare
HansMuller
pushed a commit
that referenced
this pull request
Dec 16, 2015
Correct the TabBarView swipe selection change animation The TabBarSelection change animation needs to start where the fling's drag gesture ended rather than from zero. The intial vlaue of progress for the TabBarSelection's performance is now converted from the range used during an interactive drag, to the range used when animating from the previously selected tab to the new one. TabBarSelection now requires a maxIndex parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TabBarSelection change animation needs to start where the fling's drag gesture ended rather than from zero. The intial vlaue of progress for the TabBarSelection's performance is now converted from the range used during an interactive drag, to the range used when animating from the previously selected tab to the new one.
TabBarSelection now requires a maxIndex parameter.