Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci.yaml] Migrate roller to cocoon scheduler #99162

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

CaseyHillers
Copy link
Contributor

#92300

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@@ -230,7 +230,6 @@ targets:
properties:
tags: >
["framework","hostonly","shard"]
scheduler: luci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bringup: true to validate first?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since flutter/flutter's ci.yaml changes a lot, i'd rather leave it blocking. I plan to use the engine PR to validate before landing this one.

@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/99162

@goderbauer goderbauer added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels Mar 1, 2022
@CaseyHillers
Copy link
Contributor Author

Friendly ping. Engine ci.yaml roller is running fine on the cocoon scheduler

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fluttergithubbot fluttergithubbot merged commit 3131699 into master Mar 1, 2022
@fluttergithubbot fluttergithubbot deleted the CaseyHillers-patch-1 branch March 1, 2022 20:01
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
CaseyHillers added a commit that referenced this pull request Mar 2, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants