Revert "reads min/target sdk versions from localproperties" #99191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37a1aaf.
flutter-dashboard
bot
added
d: api docs
camsim99
approved these changes
Feb 28, 2022
fluttergithubbot
deleted the
revert-98450-95533-reads-mintargetsdk-localproperties
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
|
@blasten Sorry I couldn't see this earlier... There were some improvements in the PR that can be adapted to maintain the flutter.minSdkVersion, do you want me to push a PR with these changes as well the comments mentioned on #95533 (comment) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #98450
Broke the Flutter roll into the plugins repo flutter/plugins#4925
I'd suggest we add comments to
android/app/build.gradle, so folks know that can replace theflutter.*constants.
This keeps Flutter apps a bit more consistent with other use cases.
e.g. Flutter plugins, add-to-app, and the rest of Android.
cc @brunotacca