Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed helper method from Scaffold #99714

Merged
merged 11 commits into from
Jun 3, 2022
Merged

fix: Removed helper method from Scaffold #99714

merged 11 commits into from
Jun 3, 2022

Conversation

albertodev01
Copy link
Contributor

This PR fixes #99712 by replacing a helper method with an actual widget inside the build method

If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Renzo-Olivares
Copy link
Contributor

@albertodev01 LGTM could you request a text-exemption from @Hixie on Discord. Thank you!

@Hixie
Copy link
Contributor

Hixie commented Mar 25, 2022

test-exempt: code refactor with no semantic change

Renzo-Olivares
Renzo-Olivares approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Piinks
Piinks approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it looks like the Google testing shard is stuck. Can you update your branch with the latest from master and push to refresh? Thank you!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented May 13, 2022

Hey @albertodev01 it looks like this needs to be rebased rather than merged.

@guidezpl guidezpl merged commit 032dc54 into flutter:master Jun 3, 2022
@albertodev01 albertodev01 deleted the scaffold_fix branch June 3, 2022 11:57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
7873265 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
dbcb6ac 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
5f66454 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 4, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
9e0d8ab 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
e21c8f6 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
3e30287 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 5, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
f19e18b 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
4bf8553 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
9fc7356 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
29c211c 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
a6088b7 
…9714)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 6, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
464fde0 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
78a6b96 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
9b74ddf 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
6c34377 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
ae32134 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
70ac18e 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
d2c9444 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
0c84514 
…9714)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@albertodev01 @guidezpl @camsim99
fix: Removed helper method from Scaffold (flutter#99714)
08179fa 
* Update autofill.dart

* fix: removed helper method

Co-authored-by: Pierre-Louis Guidez <plg@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
032dc5428 fix: Removed helper method from Scaffold (flutter/flutter#9…
dbec7ef 
…9714)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
032dc54 fix: Removed helper method from Scaffold (flutter/flutter#99714)
e741536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary helper method that returns a widget
6 participants
@albertodev01 @Renzo-Olivares @Hixie @fluttergithubbot @Piinks @guidezpl