Fix AndroidView offset and resize #99888
Conversation
flutter-dashboard
bot
added
the
framework
blasten
force-pushed
the
android_view_fixes
branch
from
4f9b431
to
2bc508c
Compare
blasten
force-pushed
the
android_view_fixes
branch
from
c622a61
to
63a9ba9
Compare
|
|
||
| @override | ||
| Future<void> setSize(Size size) async { | ||
| Future<Size> setSize(Size size) async { |
There was a problem hiding this comment.
This is a breaking change. Can we just add a new method to get the updated size?
There was a problem hiding this comment.
This is necessary. When someone overrides setSize, they do it for testing purposes.
e.g. to provide a fake implementation of this controller. If there's a new method that makes calls over the channel, then failures are expected as a result.
There was a problem hiding this comment.
Why would it be necessary, can we have an ivar to save it after calling void setSize, and a getter to get the value of that ivar?
It is also a little confusing to get a new Size object when you setSize.
There was a problem hiding this comment.
Can we query all flutter projects to make sure there's no subclasses of AndroidViewController that overrides setSize?
There was a problem hiding this comment.
I didn't see any subclasses other than FakeAndroidViewController already defined within the framework (google3 and public repos). In general, this controller is an internal implementation of the framework; and it's very tightly coupled to the platform implementation.
I'm also not aware of any use case (other than maybe a fake?) that requires overriding or extending functionality.
There was a problem hiding this comment.
At a high level, this API seems like it should have been private. I don't know why it was made public.
|
|
||
| @override | ||
| Future<void> setOffset(Offset off) async { | ||
| if (off == _off || _state != _AndroidViewState.created) |
There was a problem hiding this comment.
What is the significance of _state != _AndroidViewState.created here? By looking at the code I don'
t understand why we don't need to set a new off if the state is created. Could you add a comment to explain? Or maybe find a better condition.
There was a problem hiding this comment.
Done. Added a comment to clarify.
|
|
||
| @override | ||
| Future<void> setOffset(Offset off) async { | ||
| if (off == _off || _state != _AndroidViewState.created) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| @@ -1043,13 +1092,13 @@ class TextureAndroidViewController extends AndroidViewController { | |||
|
|
|||
| @override | |||
| Future<void> _sendCreateMessage() async { | |||
| assert(!_size.isEmpty, 'trying to create $TextureAndroidViewController without setting a valid size.'); | |||
| assert(!_initialSize.isEmpty, 'trying to create $TextureAndroidViewController without setting a valid size.'); | |||
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| // native view on the screen | ||
| void _setOffset() { | ||
| SchedulerBinding.instance.addPostFrameCallback((_) async { | ||
| if (!_isDisposed) { |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
blasten
force-pushed
the
android_view_fixes
branch
from
f6e2c3a
to
fb1a0d9
Compare
Fixes
AndroidViewby correcting how the texture is resized and setting the right offset, so a11y highlightsare drawn.
This PR replaces #97628
Engine PR: flutter/engine#31198
Related Issue: #96679