Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router_builder]Update the way to pass the extra param in router_config #3005

Merged
merged 13 commits into from Feb 27, 2023
Merged

[go_router_builder]Update the way to pass the extra param in router_config #3005

merged 13 commits into from Feb 27, 2023

Conversation

hangyujin
Copy link
Contributor

@hangyujin hangyujin commented Dec 27, 2022 •
edited

issue: flutter/flutter#111837

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@hangyujin hangyujin changed the title Remove extra param from go_router_builder [go_router_builder]Update router_config to not passing extra unconditionally Dec 27, 2022
@hangyujin
update extra
1d2a3ba 
This reverts commit 36213a4.

remove extra

update log

update tests

update

Update CHANGELOG.md

lint

lint
@hangyujin hangyujin changed the title [go_router_builder]Update router_config to not passing extra unconditionally [go_router_builder]Update the way to pass the extra param in router_config Dec 27, 2022
@stuartmorgan
Copy link
Contributor

@hangyujin What's the status of this PR? Are you planning on updating it based on the discussion above?

@chunhtai
Copy link
Contributor

chunhtai commented Feb 2, 2023

(triage) @hangyujin said she will come back to this pr soon.

@hangyujin
Merge branch 'main' of https://github.com/flutter/packages into remov…
0acae1b 
…e-extra-2
@hangyujin
test
f285527 
Revert "test"

This reverts commit d748242967a0a3805364d438bc81f39cf3804cc7.

Update main.dart
chunhtai
chunhtai previously approved these changes Feb 16, 2023
View reviewed changes
packages/go_router_builder/CHANGELOG.md Outdated Show resolved Hide resolved
packages/go_router_builder/example/lib/main.g.dart Outdated Show resolved Hide resolved
packages/go_router_builder/lib/src/route_config.dart Outdated Show resolved Hide resolved
@chunhtai chunhtai dismissed their stale review February 16, 2023 19:58

accidentally approved

chunhtai
chunhtai approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hangyujin hangyujin added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@auto-submit auto-submit bot merged commit a2c5062 into flutter:main Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
a2c5062 [go_router_builder]Update the way to pass the extra param i…
31e46a5 
…n router_config (flutter/packages#3005)
navaronbracke pushed a commit to navaronbracke/packages that referenced this pull request Mar 3, 2023
@hangyujin @navaronbracke
[go_router_builder]Update the way to pass the extra param in router…
ae9bcfd 
…_config (flutter#3005)

[go_router_builder]Update the way to pass the `extra` param in router_config
GP4cK added a commit to GP4cK/packages that referenced this pull request Mar 10, 2023
@GP4cK
Squashed commit of the following:
4d6f19c 
commit 6d24151
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 9 16:19:48 2023 -0800

    [ci] Fix federated safety check (flutter#3417)

    [ci] Fix federated safety check

commit 574b8ea
Author: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Date:   Thu Mar 9 18:40:04 2023 -0500

    update bad imports (flutter#3427)

    [webview_flutter_platform_interface][webview_flutter_wkwebview] Fix inconsistent imports

commit eb2fe26
Author: Navaron Bracke <brackenavaron@gmail.com>
Date:   Thu Mar 9 17:31:19 2023 +0100

    [espresso] Enable warnings as errors (flutter#3414)

    [espresso] Enable warnings as errors

commit 3b29183
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Mar 9 11:22:33 2023 -0500

    Roll Flutter (stable) from c07f78888884 to 2ad6cd72c040 (5 revisions) (flutter#3426)

    Roll Flutter (stable) from c07f78888884 to 2ad6cd72c040 (5 revisions)

commit 8a7dead
Author: Chris Yang <ychris@google.com>
Date:   Thu Mar 9 04:10:02 2023 -0800

    Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes (flutter#3420)

    Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes

commit 3814ec4
Author: Tarrin Neal <tarrinneal@gmail.com>
Date:   Thu Mar 9 03:22:21 2023 -0800

    [image_picker] moves Android 13 image picker to options (flutter#3370)

    [image_picker] moves Android 13 image picker to options

commit 88ca9e2
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 9 02:57:13 2023 -0800

    Revert "[video_player] Passing http headers to file constructor  (flutter#3266)" (flutter#3424)

    This reverts commit 73e7ef7.

commit 73e7ef7
Author: Abdelaziz Mahdy <zezohassam@gmail.com>
Date:   Thu Mar 9 02:53:35 2023 +0200

    [video_player] Passing http headers to file constructor  (flutter#3266)

    [video_player] Passing http headers to file constructor

commit e10e945
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Mar 8 22:13:48 2023 +0000

    Bump actions/labeler from 4.0.2 to 4.0.3 (flutter#3411)

    Bump actions/labeler from 4.0.2 to 4.0.3

commit 4b03866
Author: Andrew Kolos <andrewrkolos@gmail.com>
Date:   Wed Mar 8 20:54:02 2023 +0000

    [flutter_markdown] add AssetManifest.bin to TestAssetBundle (flutter#3422)

    [flutter_markdown] add AssetManifest.bin to TestAssetBundle

commit 46c6333
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 8 10:55:25 2023 -0800

    [in_app_purchase] Enable -Werror for Android (flutter#3403)

    [in_app_purchase] Enable -Werror for Android

commit 95a8a76
Author: Rexios <rexios@rexios.dev>
Date:   Wed Mar 8 13:31:30 2023 -0500

    Update android configuration (flutter#3408)

    [google_maps_flutter] Update example android configuration

commit 6d5cb85
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 8 09:07:46 2023 -0800

    [various] Clarify endorsement in READMEs (flutter#3404)

    [various] Clarify endorsement in READMEs

commit a4d3d16
Author: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Date:   Wed Mar 8 10:28:07 2023 -0500

    [webview_flutter_android] Adds a WebViewFlutterApi (flutter#3324)

    [webview_flutter_android] Adds a WebViewFlutterApi

commit 9bfef95
Author: Anuruddha <anupremv@gmail.com>
Date:   Wed Mar 8 10:06:03 2023 +0800

    [webview_flutter] Add android `webSettings.setTextZoom` api (flutter#3298)

    [webview_flutter] Add android `webSettings.setTextZoom` api

commit 4aa259a
Author: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Date:   Tue Mar 7 16:33:03 2023 -0800

    [pigeon] Removed gaaclarke from the readme (flutter#3395)

commit 15ae705
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 13:49:16 2023 -0800

    [go_router_builder] Remove Flutter SDK constraint (flutter#3406)

    [go_router_builder] Remove Flutter SDK constraint

commit 036cb1e
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 12:11:26 2023 -0800

    [camera] Revert Android part of flutter#3272 (flutter#3405)

    Reverts the Android part of flutter#3272 (commit d311478), which introduced significant crash flake in the tests.

commit 5eefd07
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 11:43:38 2023 -0800

    Update CODEOWNERS (flutter#3402)

    Update CODEOWNERS

commit 55f4298
Author: Evan Mesterhazy <evan.mesterhazy@gmail.com>
Date:   Tue Mar 7 13:55:47 2023 -0500

    [go_router] Fix a typo in the ShellRoute docstring (flutter#3378)

    [go_router] Fix a typo in the ShellRoute docstring

commit d311478
Author: Braden Bagby <33461698+BradenBagby@users.noreply.github.com>
Date:   Tue Mar 7 11:54:53 2023 -0700

    [camera] Reland implementations of flip/change camera while recording (flutter#3272)

    [camera] Reland implementations of flip/change camera while recording

commit 843bd8c
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 09:25:16 2023 -0800

    [pigeon] Minor updates for pana (flutter#3397)

    - Removes the Flutter SDK constraint; as far as I remember and can tell
      from git history, we only did this to prevent pigeon from running
      tests on unsupported versions before the repo tooling supported
      minimum Dart versions.
    - Removes an unnecessary null check. We intentionally have that analysis
      option off for the repo as long as Flutter supports non-strong-mode
      code, but the specific check here isn't subject to client code so
      isn't useful to keep.

    Part (maybe all?) of flutter/flutter#122029

commit e9c15fe
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 08:45:42 2023 -0800

    [various] Remove enableR8 (flutter#3400)

    [various] Remove enableR8

commit c90d823
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 08:23:56 2023 -0800

    [google_maps_flutter] Enable -Werror for Android (flutter#3399)

    [google_maps_flutter] Enable -Werror for Android

commit c40f189
Author: Navaron Bracke <brackenavaron@gmail.com>
Date:   Tue Mar 7 16:59:36 2023 +0100

    [camera_android] Fix camera android deprecation warning for CamcorderProfile.get() (flutter#3273)

    [camera_android] Fix camera android deprecation warning for CamcorderProfile.get()

commit 789e3a7
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Sat Mar 4 10:28:18 2023 -0800

    [various] Align Flutter and Dart SDK constraints (flutter#3349)

    As described in flutter/flutter#121684, we currently have inconsistencies between Flutter SDK constraints and Dart SDK constraints; we have often updated only the former. This PR:
    1. Adds CI enforcement via the repo tooling that the minimum versions are consistent.
    2. Adds a new repo tooling command to update SDK constraints, to help mass-fix all the violations of the new enforcement in step 1 (and for future mass changes, such as when we update our test matrix and mass-drop support for versions that are no longe tested).
        - In all cases, the looser constraint was updated to match the more restrictive constraint, such that there's no actual change in what Flutter version any package actually supports.
    3. Runs `dart fix --apply` over all changed packages to automatically fix all of the analysis failures caused by step 2 suddenly making all of our packages able to use `super` parameters.

    Fixes flutter/flutter#121684
    Fixes flutter/flutter#121685

commit f14fae7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Mar 4 11:03:24 2023 -0500

    Roll Flutter from c590086bcc58 to f2f80059ff87 (14 revisions) (flutter#3373)

    Roll Flutter from c590086bcc58 to f2f80059ff87 (14 revisions)

commit 405e465
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 18:53:20 2023 -0800

    [webview_flutter] Enable warnings-as-errors on Android (flutter#3356)

    [webview_flutter] Enable warnings-as-errors on Android

commit b220ace
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 17:17:24 2023 -0800

    [ci] Increase Android platform test sharding (flutter#3365)

    [ci] Increase Android platform test sharding

commit 74d64cd
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Mar 3 14:08:05 2023 -0500

    Roll Flutter from f032a4d64891 to c590086bcc58 (69 revisions) (flutter#3366)

    Roll Flutter from f032a4d64891 to c590086bcc58 (69 revisions)

commit 4aedb85
Author: Reid Baker <reidbaker@google.com>
Date:   Fri Mar 3 13:42:22 2023 -0500

    [Espresso] Update truth package to 1.1.3 (flutter#3358)

    [Espresso] Update truth package to 1.1.3

commit dbce04e
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 08:49:35 2023 -0800

    [google_maps] Relax the Android renderer requset test (flutter#3364)

    Updates the "initialized with latest renderer" test to just test that
    the rest resulted in some valid response, since we can't actually
    control what the server returns; the request is non-binding, and there
    are cases where (e.g., depending on the device details) the legacy
    renderer will be returned regardless.

commit ca7205b
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 08:27:12 2023 -0800

    [pigeon] Only check generated files on master (flutter#3357)

    [pigeon] Only check generated files on master

commit da635f0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Mar 3 15:57:18 2023 +0000

    [webview]: Bump androidx.webkit:webkit from 1.5.0 to 1.6.0 in /packages/webview_flutter/webview_flutter_android/android (flutter#3243)

    [webview]: Bump androidx.webkit:webkit from 1.5.0 to 1.6.0 in /packages/webview_flutter/webview_flutter_android/android

commit 2f21321
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 2 11:47:25 2023 -0800

    [ci+various] Partially enable javac warning checks (flutter#3293)

    Since our existing `gradlew lint` check doesn't catch all warnings (notably, deprecation warnings, but also others like raw values), this:
    - Configures our plugin example apps to enable `-Xlint:all -Werror` for the javac for the plugin project, so that we also get javac lint coverage in CI. This is done in the example app so that it won't affect plugin clients.
    - Adds a check to `lint-android` that the example is configured this way, so that we don't forget to set it up when adding new plugins (or re-generating plugin examples from template).

    Where it was trivial for me to just fix existing violations, I did so in this PR. For the rest that had violations, I commented out the enabling of the flags, with a TODO. Normally we would do this kind of thing with a `script/configs` file to opt packages out of a new check, but since this is part of an existing check rather than a whole new command, doing it that way would disable `gradlew lint` for those packages as well. Making a whole new command seemed more complex for the long term, so this seemed like the best short term option. We should try to remove as many of these opt-outs as possible ASAP.

    Part of flutter/flutter#91868

commit b7812d9
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:34 2023 -0800

    [webview_flutter] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3336)

commit 60637eb
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:19 2023 -0800

    [local_auth] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3335)

commit 5e6b3b4
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:03 2023 -0800

    [google_sign_in] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3330)

commit ad82209
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:02:40 2023 -0800

    [google_maps_flutter] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3329)

commit 18761a2
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:02:18 2023 -0800

    [video_player] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3328)

commit e2a911b
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:01:57 2023 -0800

    [file_selector] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3325)

commit bfdb4eb
Author: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com>
Date:   Fri Mar 3 02:26:45 2023 +0800

    [go_router_builder] Fix the example for default values in the README (flutter#3231)

    [go_router_builder] Fix the example for default values in the README

commit 875a403
Author: Reid Baker <reidbaker@google.com>
Date:   Thu Mar 2 11:15:06 2023 -0500

    Update annotation and espresso dependencies (flutter#3271)

    * Update annotation and espresso dependencies

    * Migrate camera_android to use flutter.compileSdkVersion

    * Migrate camera_android_camerax to use flutter.compileSdkVersion

    * Migrate camera_camera to use flutter.compileSdkVersion

    * Migrate espresso to use flutter.compileSdkVersion
    Fix example app to launch with multidex
    partial work on flutter/flutter/issues/121423

    * Mass replace for flutter.compileSdkVersion on all "apps"

    * Mass update non app build.gradle files to compileSdkVersion 33

    * Update changelog next

    * Fix misspelling and combine annotation update with compileSdkVersion update

    * Remove web changelog, update messages to apply to only the changes for that plugin

    * Remove all changelog changes from packages that did not have a build.gradle update

    * formatting update

    * Add copyright to multidex application because it fails repro checks

    * Remove more unneeded changelog files unrelated to android

    * Remove CHANGELOG entries for packages where only the example app was updated

    * Fix bad merge in changelog files and change update to updates in remainding changelog files

    * Fix more update -> updates

commit 0954499
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 1 03:55:21 2023 -0800

    [tool] Provide a --base-branch flag (flutter#3322)

    [tool] Provide a --base-branch flag

commit 7ec6a77
Author: Preston Schwartz <preston.schwartz505@gmail.com>
Date:   Tue Feb 28 19:26:06 2023 -0600

    [image_picker_android] Adds Android 13 photo picker functionality (flutter#3267)

    [image_picker_android] Adds Android 13 photo picker functionality

commit 588c5f4
Author: Paolo Rotolo <rotolopao@gmail.com>
Date:   Wed Mar 1 02:04:39 2023 +0100

    [pigeon] Add Kotlin parameters to run pigeon command (flutter#3260)

    [pigeon] Add Kotlin parameters to run pigeon command

commit ed1f780
Author: Jenn Magder <magder@google.com>
Date:   Tue Feb 28 16:10:40 2023 -0800

    [image_picker] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3327)

    [image_picker] Update minimum Flutter version to 3.3 and iOS 11

commit 4397336
Author: Jenn Magder <magder@google.com>
Date:   Tue Feb 28 13:22:55 2023 -0800

    [go_router] Update example app to iOS 11 (flutter#3326)

    [go_router] Update example app to iOS 11

commit b98cd1f
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Feb 28 11:45:04 2023 -0800

    [pigeon] Enable warnings as errors for remaining languages (flutter#3317)

    [pigeon] Enable warnings as errors for remaining languages

commit 475cf82
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 28 10:54:50 2023 -0500

    Roll Flutter from c8d80163b03f to f032a4d64891 (17 revisions) (flutter#3320)

    Roll Flutter from c8d80163b03f to f032a4d64891 (17 revisions)

commit e20c1b7
Author: Tarrin Neal <tarrinneal@gmail.com>
Date:   Tue Feb 28 07:54:49 2023 -0800

    [pigeon] removes safe casting from nullables in kotlin and swift (flutter#3284)

    [pigeon] removes safe casting from nullables in kotlin and swift

commit f39c97d
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 27 22:17:48 2023 -0500

    Manual roll Flutter from 7175de4fe686 to c8d80163b03f (96 revisions) (flutter#3319)

    Manual roll Flutter from 7175de4fe686 to c8d80163b03f (96 revisions)

commit 3a8103e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 27 21:58:09 2023 +0000

    Bump lewagon/wait-on-check-action from 1.2.0 to 1.3.1 (flutter#3210)

    Bump lewagon/wait-on-check-action from 1.2.0 to 1.3.1

commit 058ed5b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 27 13:58:00 2023 -0800

    Bump github/codeql-action from 2.2.1 to 2.2.5 (flutter#3308)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.1 to 2.2.5.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@3ebbd71...32dc499)

    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a2c5062
Author: hangyu <jhy03261997@gmail.com>
Date:   Mon Feb 27 13:21:49 2023 -0800

    [go_router_builder]Update the way to pass the `extra` param in router_config (flutter#3005)

    [go_router_builder]Update the way to pass the `extra` param in router_config

commit 533be95
Author: Jenn Magder <magder@google.com>
Date:   Mon Feb 27 13:03:57 2023 -0800

    [camera] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3296)

    [camera] Update minimum Flutter version to 3.3 and iOS 11

commit 7ebf1d4
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Mon Feb 27 07:02:13 2023 -0800

    [tool] Always run publish check (flutter#3279)

    [tool] Always run publish check

commit ec4a546
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 26 12:36:23 2023 -0500

    Roll Flutter (stable) from 994429713884 to c07f78888884 (5 revisions) (flutter#3305)

    Roll Flutter (stable) from 994429713884 to c07f78888884 (5 revisions)

commit 2e04050
Author: David Iglesias <ditman@gmail.com>
Date:   Fri Feb 24 16:58:06 2023 -0800

    [ci] Fix some web-platform_tests. (flutter#3285)

    [ci] Fix some web-platform_tests.

commit ad48ee5
Author: dddrop <go@dddrop.dev>
Date:   Sat Feb 25 02:24:00 2023 +0900

    [go_router] Fix some broken links in doc (flutter#3288)

    [go_router] Fix some broken links in doc

commit 58ac45e
Author: Mirko Mucaria <Skogsfrae@users.noreply.github.com>
Date:   Thu Feb 23 23:46:11 2023 +0100

    [go_router_builder] Add support for Iterable, List  and Set to TypedGoRoute (flutter#2679)

    * fixes #108437 support for iterable, list and set

    * fixes #108437 url encoding for iterable, list and set

    * fixes #108437 tests

    * format and analysis fix

    * fix string encoding

    * format

    * removed unused helper name

    * fix nullability checks for query params encoding

    * fix all_types.dart for new go router version

    * rebased to upstream

    * version

    * missing file regeneration

commit 0edae25
Author: John Ryan <ryjohn@google.com>
Date:   Thu Feb 23 13:59:49 2023 -0800

    Export super types in route_data.dart library (flutter#3286)
@reidbaker reidbaker mentioned this pull request Mar 20, 2023
Merged
10 tasks
@Skogsfrae Skogsfrae mentioned this pull request May 3, 2023
Open
2 tasks
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@hangyujin @nploi
[go_router_builder]Update the way to pass the extra param in router…
ad062f8 
…_config (flutter#3005)

[go_router_builder]Update the way to pass the `extra` param in router_config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router_builder
Projects
None yet
Milestone
No milestone
3 participants
@hangyujin @stuartmorgan @chunhtai