Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes #3420

Merged
merged 3 commits into from Mar 9, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Mar 8, 2023

Fixes for the manual roll + the actual roll.
Fixes:

  1. New format style change.

Roll details below:

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions)

Manual roll requested by ychris@google.com

flutter/flutter@f2f8005...5a279ed

2023-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab28c582f4f4 to 694a14ca6e15 (3 revisions) (flutter/flutter#122158)
2023-03-08 jacksongardner@google.com Fix DomCSSStyleSheetExtension to work with dart2wasm. (flutter/flutter#122154)
2023-03-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from cc0fdef39f25 to ab28c582f4f4 (4 revisions) (flutter/flutter#122152)
2023-03-08 barpac02@gmail.com Fix typo in integrationDriver() function (flutter/flutter#115012)
2023-03-08 fluttergithubbot@gmail.com Marks Mac_ios hot_mode_dev_cycle_ios__benchmark to be flaky (flutter/flutter#120809)
2023-03-08 barpac02@gmail.com delete FlutterCommand.intArg(), which is not used anywhere in the codebase (flutter/flutter#122124)
2023-03-07 engine-flutter-autoroll@skia.org cc0fdef39 [web][felt] Add 'archive' target + 'profile' mode (flutter/engine#40060) (flutter/flutter#122140)
2023-03-07 annagrin@google.com Add printing on failure to web hotrestart tests (flutter/flutter#122115)
2023-03-07 72562119+tgucio@users.noreply.github.com Use tearoffs (flutter/flutter#122091)
2023-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8510f554d3fa to 89627fda3055 (5 revisions) (flutter/flutter#122135)
2023-03-07 mdebbar@google.com [web] Ensure CanvasKit is served from the correct location (flutter/flutter#121902)
2023-03-07 109253501+pdblasi-google@users.noreply.github.com Reland: Removes single window assumptions from flutter_test (flutter/flutter#122060)
2023-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 811dcfb46101 to 8510f554d3fa (3 revisions) (flutter/flutter#122126)
2023-03-07 engine-flutter-autoroll@skia.org 811dcfb46 Roll Skia from 5ff664171376 to ec96c2172789 (4 revisions) (flutter/engine#40120) (flutter/flutter#122121)
2023-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e6cbe0fc22d to b3985c31295f (2 revisions) (flutter/flutter#122109)
2023-03-07 engine-flutter-autoroll@skia.org c40f189 [camera_android] Fix camera android deprecation warning for CamcorderProfile.get() (#3273) (flutter/flutter#122104)
2023-03-07 zanderso@users.noreply.github.com Revert "[integration_test] upgrade androidx test to 1.4.0 (#109547)" (flutter/flutter#122106)
2023-03-07 micaelcid10@gmail.com [integration_test] upgrade androidx test to 1.4.0 (flutter/flutter#109547)
2023-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4aab7da9f0 to 4e6cbe0fc22d (4 revisions) (flutter/flutter#122094)
2023-03-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2bd89f97e7f to 1c4aab7da9f0 (15 revisions) (flutter/flutter#122078)
2023-03-07 josh@jmatth.com Fix PlatformMenuItems with onSelectedIntent are never enabled (flutter/flutter#121885)
2023-03-07 yjbanov@google.com [web] delete unhelpful image loading e2e test (flutter/flutter#122059)
2023-03-06 leroux_bruno@yahoo.fr Add ZoomPageTransitionsBuilder.allowSnapshotting (flutter/flutter#122019)
2023-03-06 47866232+chunhtai@users.noreply.github.com Adds vmservices for getting iOS build options (flutter/flutter#121736)
2023-03-06 31859944+LongCatIsLooong@users.noreply.github.com Revert "Update test font (#121306)" (flutter/flutter#122053)
2023-03-06 christopherfujino@gmail.com pin flutter_plugin_android_lifecycle and roll other pub deps (flutter/flutter#122043)
2023-03-06 chingjun@google.com Add backward compatibility in proxied_devices. (flutter/flutter#122040)
2023-03-06 31859944+LongCatIsLooong@users.noreply.github.com Update test font (flutter/flutter#121306)
2023-03-06 andrewrkolos@gmail.com Reland "Speed up first asset load by using the binary-formatted asset manifest for image resolution (flutter/flutter#121322)
2023-03-06 engine-flutter-autoroll@skia.org e2bd89f97 Roll Skia from d43c1424807e to 7e1756b42f94 (1 revision) (flutter/engine#40087) (flutter/flutter#122033)
2023-03-06 109253501+pdblasi-google@users.noreply.github.com Revert "Removes single window assumptions from flutter_test (#121549)" (flutter/flutter#122037)
2023-03-06 engine-flutter-autoroll@skia.org Roll Packages from ca7205b to 789e3a7 (7 revisions) (flutter/flutter#122026)
2023-03-06 109253501+pdblasi-google@users.noreply.github.com Removes single window assumptions from flutter_test (flutter/flutter#121549)
2023-03-06 jpnurmi@gmail.com Add missing properties to ListTileTheme.merge (flutter/flutter#121975)
2023-03-06 xxxx.xyzs.xxxx@gmail.com [tool] Proposal to multiple defines for --dart-define-from-file (flutter/flutter#120878)
2023-03-06 tessertaha@gmail.com Fix license page title color issues (flutter/flutter#121872)
2023-03-06 engine-flutter-autoroll@skia.org b6db201ea Roll Skia from ab12a43ea332 to d43c1424807e (2 revisions) (flutter/engine#40084) (flutter/flutter#122018)
2023-03-06 esouthren@google.com Bottom appbar/sheet shadow property (flutter/flutter#121406)
2023-03-06 sigurdm@google.com Use dart pub instead of dart __deprecated pub (flutter/flutter#121605)
2023-03-06 engine-flutter-autoroll@skia.org 197b6dae1 [Impeller] Round glyph locations per-run to fix per-glyph jitter (flutter/engine#40073) (flutter/flutter#122002)
2023-03-06 engine-flutter-autoroll@skia.org f8ec13dad Roll Skia from 6ab9a7f46467 to ab12a43ea332 (4 revisions) (flutter/engine#40082) (flutter/flutter#122000)
2023-03-06 engine-flutter-autoroll@skia.org 54b989378 Roll Skia from 5ce2918379b4 to 6ab9a7f46467 (1 revision) (flutter/engine#40081) (flutter/flutter#121995)
2023-03-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from de724e263264 to b4297f3cc886 (7 revisions) (flutter/flutter#121991)
2023-03-05 jason-simmons@users.noreply.github.com Fix field cleared by TestWindow.clearGestureSettingsTestValue (flutter/flutter#121956)

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan stuartmorgan added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Mar 8, 2023
@stuartmorgan
Copy link
Contributor

Overriding version/changelog checks; these are format-only.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Mar 8, 2023

Bisected that flutter/flutter#121322 seems to break the flutter_markdown test.
cc @andrewkolos @jonahwilliams

Failure details

The following ArgumentError was thrown while resolving an image:
Invalid argument(s): Unknown asset key: AssetManifest.bin

When the exception was thrown, this was the stack:
#0      TestAssetBundle.load (file:///C:/b/s/w/ir/x/w/packages/packages/flutter_markdown/test/utils.dart:207:7)
#1      CachingAssetBundle.loadStructuredBinaryData (package:flutter/src/services/asset_bundle.dart:265:5)
#2      AssetManifest.loadFromAssetBundle (package:flutter/src/services/asset_manifest.dart:19:19)
#3      AssetImage.obtainKey (package:flutter/src/painting/image_resolution.dart:284:19)
#4      ScrollAwareImageProvider.obtainKey (package:flutter/src/widgets/scroll_aware_image_provider.dart:118:74)
#5      ImageProvider._createErrorHandlerAndKey (package:flutter/src/painting/image_provider.dart:480:13)
#6      ImageProvider.resolve (package:flutter/src/painting/image_provider.dart:371:5)
#7      _ImageState._resolveImage (package:flutter/src/widgets/image.dart:1098:16)
#8      _ImageState.didChangeDependencies (package:flutter/src/widgets/image.dart:1048:5)
#9      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:5133:11)
#10     ComponentElement.mount (package:flutter/src/widgets/framework.dart:4958:5)
#11     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3964:16)
#12     MultiChildRenderObjectElement.inflateWidget (package:flutter/src/widgets/framework.dart:6520:36)
#13     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6532:32)
#14     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3964:16)
#15     MultiChildRenderObjectElement.inflateWidget (package:flutter/src/widgets/framework.dart:6520:36)
#16     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6532:32)
...     Normal element mounting (41 frames)
#57     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3964:16)
#58     Element.updateChild (package:flutter/src/widgets/framework.dart:3701:18)
#59     SliverMultiBoxAdaptorElement.updateChild (package:flutter/src/widgets/sliver.dart:1715:37)
#60     SliverMultiBoxAdaptorElement.createChild.<anonymous closure> (package:flutter/src/widgets/sliver.dart:1700:20)
#61     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2713:19)
#62     SliverMultiBoxAdaptorElement.createChild (package:flutter/src/widgets/sliver.dart:1692:12)
#63     RenderSliverMultiBoxAdaptor._createOrObtainChild.<anonymous closure> (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:351:23)
#64     RenderObject.invokeLayoutCallback.<anonymous closure> (package:flutter/src/rendering/object.dart:2296:59)
#65     PipelineOwner._enableMutationsToDirtySubtrees (package:flutter/src/rendering/object.dart:1029:15)
#66     RenderObject.invokeLayoutCallback (package:flutter/src/rendering/object.dart:2296:14)
#67     RenderSliverMultiBoxAdaptor._createOrObtainChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:340:5)
#68     RenderSliverMultiBoxAdaptor.addInitialChild (package:flutter/src/rendering/sliver_multi_box_adaptor.dart:426:5)
#69     RenderSliverList.performLayout (package:flutter/src/rendering/sliver_list.dart:79:12)
#70     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#71     RenderSliverEdgeInsetsPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:139:12)
#72     RenderSliverPadding.performLayout (package:flutter/src/rendering/sliver_padding.dart:365:11)
#73     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#74     RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:537:13)
#75     RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1602:12)
#76     RenderViewport.performLayout (package:flutter/src/rendering/viewport.dart:1509:20)
#77     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#78     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#79     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#80     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#81     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#82     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#83     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#84     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#85     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#86     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#87     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#88     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#89     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#90     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#91     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#92     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#93     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#94     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#95     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#96     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#97     RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#98     RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#99     RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#100    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#101    RenderCustomPaint.performLayout (package:flutter/src/rendering/custom_paint.dart:549:11)
#102    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#103    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#104    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#105    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#106    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#107    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#108    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#109    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#110    RenderConstrainedBox.performLayout (package:flutter/src/rendering/proxy_box.dart:297:14)
#111    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#112    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#113    RenderPositionedBox.performLayout (package:flutter/src/rendering/shifted_box.dart:438:14)
#114    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#115    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#116    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#117    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#118    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#119    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#120    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#121    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#122    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#123    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#124    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#125    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#126    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#127    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#128    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#129    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#130    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#131    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#132    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#133    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#134    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#135    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#136    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#137    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#138    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#139    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#140    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#141    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#142    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#143    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#144    RenderOffstage.performLayout (package:flutter/src/rendering/proxy_box.dart:3753:13)
#145    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#146    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#147    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#148    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#149    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#150    _RenderTheaterMixin.performLayout (package:flutter/src/widgets/overlay.dart:832:15)
#151    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#152    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#153    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#154    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#155    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#156    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#157    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#158    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#159    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#160    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#161    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#162    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#163    RenderCustomPaint.performLayout (package:flutter/src/rendering/custom_paint.dart:549:11)
#164    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#165    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#166    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#167    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#168    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#169    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#170    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#171    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#172    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#173    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#174    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#175    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#176    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#177    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#178    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#179    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#180    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#181    RenderProxyBoxMixin.performLayout (package:flutter/src/rendering/proxy_box.dart:122:14)
#182    RenderObject.layout (package:flutter/src/rendering/object.dart:2185:7)
#183    RenderBox.layout (package:flutter/src/rendering/box.dart:2386:11)
#184    RenderView.performLayout (package:flutter/src/rendering/view.dart:173:14)
#185    RenderObject._layoutWithoutResize (package:flutter/src/rendering/object.dart:2024:7)
#186    PipelineOwner.flushLayout (package:flutter/src/rendering/object.dart:993:18)
#187    AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:1343:23)
#188    RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:368:5)
#189    SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1286:15)
#190    SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1216:9)
#191    AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:1191:9)
#194    TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#195    AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:1177:27)
#196    WidgetTester._pumpWidget (package:flutter_test/src/widget_tester.dart:592:20)
#197    WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:577:14)
#200    TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:71:41)
#201    WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:576:27)
#202    defineTests.<anonymous closure>.<anonymous closure> (file:///C:/b/s/w/ir/x/w/packages/packages/flutter_markdown/test/image_test.dart:115:22)
#203    testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:170:29)
<asynchronous suspension>
<asynchronous suspension>
(elided 5 frames from dart:async and package:stack_trace)```

(This PR hasn't failed yet but you can see the failure in a previous roll: #3410)

@andrewkolos
Copy link
Contributor

andrewkolos commented Mar 8, 2023

Bisected that flutter/flutter#121322 seems to break the flutter_markdown test.

Looks like this method in TestAssetBundle needs to be updated to include AssetManifest.bin. I'll look into it further.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Mar 8, 2023

Need to sync main after #3422 lands.

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 9, 2023

auto label is removed for flutter/packages, pr: 3420, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 9, 2023

auto label is removed for flutter/packages, pr: 3420, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 8a7dead into flutter:main Mar 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
@cyanglaz cyanglaz deleted the fix_ci branch March 9, 2023 18:33
GP4cK added a commit to GP4cK/packages that referenced this pull request Mar 10, 2023
commit 6d24151
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 9 16:19:48 2023 -0800

    [ci] Fix federated safety check (flutter#3417)

    [ci] Fix federated safety check

commit 574b8ea
Author: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Date:   Thu Mar 9 18:40:04 2023 -0500

    update bad imports (flutter#3427)

    [webview_flutter_platform_interface][webview_flutter_wkwebview] Fix inconsistent imports

commit eb2fe26
Author: Navaron Bracke <brackenavaron@gmail.com>
Date:   Thu Mar 9 17:31:19 2023 +0100

    [espresso] Enable warnings as errors (flutter#3414)

    [espresso] Enable warnings as errors

commit 3b29183
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Thu Mar 9 11:22:33 2023 -0500

    Roll Flutter (stable) from c07f78888884 to 2ad6cd72c040 (5 revisions) (flutter#3426)

    Roll Flutter (stable) from c07f78888884 to 2ad6cd72c040 (5 revisions)

commit 8a7dead
Author: Chris Yang <ychris@google.com>
Date:   Thu Mar 9 04:10:02 2023 -0800

    Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes (flutter#3420)

    Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes

commit 3814ec4
Author: Tarrin Neal <tarrinneal@gmail.com>
Date:   Thu Mar 9 03:22:21 2023 -0800

    [image_picker] moves Android 13 image picker to options (flutter#3370)

    [image_picker] moves Android 13 image picker to options

commit 88ca9e2
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 9 02:57:13 2023 -0800

    Revert "[video_player] Passing http headers to file constructor  (flutter#3266)" (flutter#3424)

    This reverts commit 73e7ef7.

commit 73e7ef7
Author: Abdelaziz Mahdy <zezohassam@gmail.com>
Date:   Thu Mar 9 02:53:35 2023 +0200

    [video_player] Passing http headers to file constructor  (flutter#3266)

    [video_player] Passing http headers to file constructor

commit e10e945
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Mar 8 22:13:48 2023 +0000

    Bump actions/labeler from 4.0.2 to 4.0.3 (flutter#3411)

    Bump actions/labeler from 4.0.2 to 4.0.3

commit 4b03866
Author: Andrew Kolos <andrewrkolos@gmail.com>
Date:   Wed Mar 8 20:54:02 2023 +0000

    [flutter_markdown] add AssetManifest.bin to TestAssetBundle (flutter#3422)

    [flutter_markdown] add AssetManifest.bin to TestAssetBundle

commit 46c6333
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 8 10:55:25 2023 -0800

    [in_app_purchase] Enable -Werror for Android (flutter#3403)

    [in_app_purchase] Enable -Werror for Android

commit 95a8a76
Author: Rexios <rexios@rexios.dev>
Date:   Wed Mar 8 13:31:30 2023 -0500

    Update android configuration (flutter#3408)

    [google_maps_flutter] Update example android configuration

commit 6d5cb85
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 8 09:07:46 2023 -0800

    [various] Clarify endorsement in READMEs (flutter#3404)

    [various] Clarify endorsement in READMEs

commit a4d3d16
Author: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com>
Date:   Wed Mar 8 10:28:07 2023 -0500

    [webview_flutter_android] Adds a WebViewFlutterApi (flutter#3324)

    [webview_flutter_android] Adds a WebViewFlutterApi

commit 9bfef95
Author: Anuruddha <anupremv@gmail.com>
Date:   Wed Mar 8 10:06:03 2023 +0800

    [webview_flutter] Add android `webSettings.setTextZoom` api (flutter#3298)

    [webview_flutter] Add android `webSettings.setTextZoom` api

commit 4aa259a
Author: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
Date:   Tue Mar 7 16:33:03 2023 -0800

    [pigeon] Removed gaaclarke from the readme (flutter#3395)

commit 15ae705
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 13:49:16 2023 -0800

    [go_router_builder] Remove Flutter SDK constraint (flutter#3406)

    [go_router_builder] Remove Flutter SDK constraint

commit 036cb1e
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 12:11:26 2023 -0800

    [camera] Revert Android part of flutter#3272 (flutter#3405)

    Reverts the Android part of flutter#3272 (commit d311478), which introduced significant crash flake in the tests.

commit 5eefd07
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 11:43:38 2023 -0800

    Update CODEOWNERS (flutter#3402)

    Update CODEOWNERS

commit 55f4298
Author: Evan Mesterhazy <evan.mesterhazy@gmail.com>
Date:   Tue Mar 7 13:55:47 2023 -0500

    [go_router] Fix a typo in the ShellRoute docstring (flutter#3378)

    [go_router] Fix a typo in the ShellRoute docstring

commit d311478
Author: Braden Bagby <33461698+BradenBagby@users.noreply.github.com>
Date:   Tue Mar 7 11:54:53 2023 -0700

    [camera] Reland implementations of flip/change camera while recording (flutter#3272)

    [camera] Reland implementations of flip/change camera while recording

commit 843bd8c
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 09:25:16 2023 -0800

    [pigeon] Minor updates for pana (flutter#3397)

    - Removes the Flutter SDK constraint; as far as I remember and can tell
      from git history, we only did this to prevent pigeon from running
      tests on unsupported versions before the repo tooling supported
      minimum Dart versions.
    - Removes an unnecessary null check. We intentionally have that analysis
      option off for the repo as long as Flutter supports non-strong-mode
      code, but the specific check here isn't subject to client code so
      isn't useful to keep.

    Part (maybe all?) of flutter/flutter#122029

commit e9c15fe
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 08:45:42 2023 -0800

    [various] Remove enableR8 (flutter#3400)

    [various] Remove enableR8

commit c90d823
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Mar 7 08:23:56 2023 -0800

    [google_maps_flutter] Enable -Werror for Android (flutter#3399)

    [google_maps_flutter] Enable -Werror for Android

commit c40f189
Author: Navaron Bracke <brackenavaron@gmail.com>
Date:   Tue Mar 7 16:59:36 2023 +0100

    [camera_android] Fix camera android deprecation warning for CamcorderProfile.get() (flutter#3273)

    [camera_android] Fix camera android deprecation warning for CamcorderProfile.get()

commit 789e3a7
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Sat Mar 4 10:28:18 2023 -0800

    [various] Align Flutter and Dart SDK constraints (flutter#3349)

    As described in flutter/flutter#121684, we currently have inconsistencies between Flutter SDK constraints and Dart SDK constraints; we have often updated only the former. This PR:
    1. Adds CI enforcement via the repo tooling that the minimum versions are consistent.
    2. Adds a new repo tooling command to update SDK constraints, to help mass-fix all the violations of the new enforcement in step 1 (and for future mass changes, such as when we update our test matrix and mass-drop support for versions that are no longe tested).
        - In all cases, the looser constraint was updated to match the more restrictive constraint, such that there's no actual change in what Flutter version any package actually supports.
    3. Runs `dart fix --apply` over all changed packages to automatically fix all of the analysis failures caused by step 2 suddenly making all of our packages able to use `super` parameters.

    Fixes flutter/flutter#121684
    Fixes flutter/flutter#121685

commit f14fae7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sat Mar 4 11:03:24 2023 -0500

    Roll Flutter from c590086bcc58 to f2f80059ff87 (14 revisions) (flutter#3373)

    Roll Flutter from c590086bcc58 to f2f80059ff87 (14 revisions)

commit 405e465
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 18:53:20 2023 -0800

    [webview_flutter] Enable warnings-as-errors on Android (flutter#3356)

    [webview_flutter] Enable warnings-as-errors on Android

commit b220ace
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 17:17:24 2023 -0800

    [ci] Increase Android platform test sharding (flutter#3365)

    [ci] Increase Android platform test sharding

commit 74d64cd
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Fri Mar 3 14:08:05 2023 -0500

    Roll Flutter from f032a4d64891 to c590086bcc58 (69 revisions) (flutter#3366)

    Roll Flutter from f032a4d64891 to c590086bcc58 (69 revisions)

commit 4aedb85
Author: Reid Baker <reidbaker@google.com>
Date:   Fri Mar 3 13:42:22 2023 -0500

    [Espresso] Update truth package to 1.1.3 (flutter#3358)

    [Espresso] Update truth package to 1.1.3

commit dbce04e
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 08:49:35 2023 -0800

    [google_maps] Relax the Android renderer requset test (flutter#3364)

    Updates the "initialized with latest renderer" test to just test that
    the rest resulted in some valid response, since we can't actually
    control what the server returns; the request is non-binding, and there
    are cases where (e.g., depending on the device details) the legacy
    renderer will be returned regardless.

commit ca7205b
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Fri Mar 3 08:27:12 2023 -0800

    [pigeon] Only check generated files on master (flutter#3357)

    [pigeon] Only check generated files on master

commit da635f0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Mar 3 15:57:18 2023 +0000

    [webview]: Bump androidx.webkit:webkit from 1.5.0 to 1.6.0 in /packages/webview_flutter/webview_flutter_android/android (flutter#3243)

    [webview]: Bump androidx.webkit:webkit from 1.5.0 to 1.6.0 in /packages/webview_flutter/webview_flutter_android/android

commit 2f21321
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Thu Mar 2 11:47:25 2023 -0800

    [ci+various] Partially enable javac warning checks (flutter#3293)

    Since our existing `gradlew lint` check doesn't catch all warnings (notably, deprecation warnings, but also others like raw values), this:
    - Configures our plugin example apps to enable `-Xlint:all -Werror` for the javac for the plugin project, so that we also get javac lint coverage in CI. This is done in the example app so that it won't affect plugin clients.
    - Adds a check to `lint-android` that the example is configured this way, so that we don't forget to set it up when adding new plugins (or re-generating plugin examples from template).

    Where it was trivial for me to just fix existing violations, I did so in this PR. For the rest that had violations, I commented out the enabling of the flags, with a TODO. Normally we would do this kind of thing with a `script/configs` file to opt packages out of a new check, but since this is part of an existing check rather than a whole new command, doing it that way would disable `gradlew lint` for those packages as well. Making a whole new command seemed more complex for the long term, so this seemed like the best short term option. We should try to remove as many of these opt-outs as possible ASAP.

    Part of flutter/flutter#91868

commit b7812d9
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:34 2023 -0800

    [webview_flutter] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3336)

commit 60637eb
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:19 2023 -0800

    [local_auth] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3335)

commit 5e6b3b4
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:03:03 2023 -0800

    [google_sign_in] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3330)

commit ad82209
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:02:40 2023 -0800

    [google_maps_flutter] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3329)

commit 18761a2
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:02:18 2023 -0800

    [video_player] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3328)

commit e2a911b
Author: Jenn Magder <magder@google.com>
Date:   Thu Mar 2 11:01:57 2023 -0800

    [file_selector] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3325)

commit bfdb4eb
Author: Valentin Vignal <32538273+ValentinVignal@users.noreply.github.com>
Date:   Fri Mar 3 02:26:45 2023 +0800

    [go_router_builder] Fix the example for default values in the README (flutter#3231)

    [go_router_builder] Fix the example for default values in the README

commit 875a403
Author: Reid Baker <reidbaker@google.com>
Date:   Thu Mar 2 11:15:06 2023 -0500

    Update annotation and espresso dependencies (flutter#3271)

    * Update annotation and espresso dependencies

    * Migrate camera_android to use flutter.compileSdkVersion

    * Migrate camera_android_camerax to use flutter.compileSdkVersion

    * Migrate camera_camera to use flutter.compileSdkVersion

    * Migrate espresso to use flutter.compileSdkVersion
    Fix example app to launch with multidex
    partial work on flutter/flutter/issues/121423

    * Mass replace for flutter.compileSdkVersion on all "apps"

    * Mass update non app build.gradle files to compileSdkVersion 33

    * Update changelog next

    * Fix misspelling and combine annotation update with compileSdkVersion update

    * Remove web changelog, update messages to apply to only the changes for that plugin

    * Remove all changelog changes from packages that did not have a build.gradle update

    * formatting update

    * Add copyright to multidex application because it fails repro checks

    * Remove more unneeded changelog files unrelated to android

    * Remove CHANGELOG entries for packages where only the example app was updated

    * Fix bad merge in changelog files and change update to updates in remainding changelog files

    * Fix more update -> updates

commit 0954499
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Wed Mar 1 03:55:21 2023 -0800

    [tool] Provide a --base-branch flag (flutter#3322)

    [tool] Provide a --base-branch flag

commit 7ec6a77
Author: Preston Schwartz <preston.schwartz505@gmail.com>
Date:   Tue Feb 28 19:26:06 2023 -0600

    [image_picker_android] Adds Android 13 photo picker functionality (flutter#3267)

    [image_picker_android] Adds Android 13 photo picker functionality

commit 588c5f4
Author: Paolo Rotolo <rotolopao@gmail.com>
Date:   Wed Mar 1 02:04:39 2023 +0100

    [pigeon] Add Kotlin parameters to run pigeon command (flutter#3260)

    [pigeon] Add Kotlin parameters to run pigeon command

commit ed1f780
Author: Jenn Magder <magder@google.com>
Date:   Tue Feb 28 16:10:40 2023 -0800

    [image_picker] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3327)

    [image_picker] Update minimum Flutter version to 3.3 and iOS 11

commit 4397336
Author: Jenn Magder <magder@google.com>
Date:   Tue Feb 28 13:22:55 2023 -0800

    [go_router] Update example app to iOS 11 (flutter#3326)

    [go_router] Update example app to iOS 11

commit b98cd1f
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Tue Feb 28 11:45:04 2023 -0800

    [pigeon] Enable warnings as errors for remaining languages (flutter#3317)

    [pigeon] Enable warnings as errors for remaining languages

commit 475cf82
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Feb 28 10:54:50 2023 -0500

    Roll Flutter from c8d80163b03f to f032a4d64891 (17 revisions) (flutter#3320)

    Roll Flutter from c8d80163b03f to f032a4d64891 (17 revisions)

commit e20c1b7
Author: Tarrin Neal <tarrinneal@gmail.com>
Date:   Tue Feb 28 07:54:49 2023 -0800

    [pigeon] removes safe casting from nullables in kotlin and swift (flutter#3284)

    [pigeon] removes safe casting from nullables in kotlin and swift

commit f39c97d
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Feb 27 22:17:48 2023 -0500

    Manual roll Flutter from 7175de4fe686 to c8d80163b03f (96 revisions) (flutter#3319)

    Manual roll Flutter from 7175de4fe686 to c8d80163b03f (96 revisions)

commit 3a8103e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 27 21:58:09 2023 +0000

    Bump lewagon/wait-on-check-action from 1.2.0 to 1.3.1 (flutter#3210)

    Bump lewagon/wait-on-check-action from 1.2.0 to 1.3.1

commit 058ed5b
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Feb 27 13:58:00 2023 -0800

    Bump github/codeql-action from 2.2.1 to 2.2.5 (flutter#3308)

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.1 to 2.2.5.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@3ebbd71...32dc499)

    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a2c5062
Author: hangyu <jhy03261997@gmail.com>
Date:   Mon Feb 27 13:21:49 2023 -0800

    [go_router_builder]Update the way to pass the `extra` param in router_config (flutter#3005)

    [go_router_builder]Update the way to pass the `extra` param in router_config

commit 533be95
Author: Jenn Magder <magder@google.com>
Date:   Mon Feb 27 13:03:57 2023 -0800

    [camera] Update minimum Flutter version to 3.3 and iOS 11 (flutter#3296)

    [camera] Update minimum Flutter version to 3.3 and iOS 11

commit 7ebf1d4
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Mon Feb 27 07:02:13 2023 -0800

    [tool] Always run publish check (flutter#3279)

    [tool] Always run publish check

commit ec4a546
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Sun Feb 26 12:36:23 2023 -0500

    Roll Flutter (stable) from 994429713884 to c07f78888884 (5 revisions) (flutter#3305)

    Roll Flutter (stable) from 994429713884 to c07f78888884 (5 revisions)

commit 2e04050
Author: David Iglesias <ditman@gmail.com>
Date:   Fri Feb 24 16:58:06 2023 -0800

    [ci] Fix some web-platform_tests. (flutter#3285)

    [ci] Fix some web-platform_tests.

commit ad48ee5
Author: dddrop <go@dddrop.dev>
Date:   Sat Feb 25 02:24:00 2023 +0900

    [go_router] Fix some broken links in doc (flutter#3288)

    [go_router] Fix some broken links in doc

commit 58ac45e
Author: Mirko Mucaria <Skogsfrae@users.noreply.github.com>
Date:   Thu Feb 23 23:46:11 2023 +0100

    [go_router_builder] Add support for Iterable, List  and Set to TypedGoRoute (flutter#2679)

    * fixes #108437 support for iterable, list and set

    * fixes #108437 url encoding for iterable, list and set

    * fixes #108437 tests

    * format and analysis fix

    * fix string encoding

    * format

    * removed unused helper name

    * fix nullability checks for query params encoding

    * fix all_types.dart for new go router version

    * rebased to upstream

    * version

    * missing file regeneration

commit 0edae25
Author: John Ryan <ryjohn@google.com>
Date:   Thu Feb 23 13:59:49 2023 -0800

    Export super types in route_data.dart library (flutter#3286)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
…+ fixes (flutter#3420)

Manual roll Flutter from f2f80059ff87 to 5a279edc239f (44 revisions) + fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: google_maps_flutter p: url_launcher p: webview_flutter platform-android platform-ios platform-web
Projects
None yet
4 participants