Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Many] i123017 integration annotation documentation #3495

Merged
merged 3 commits into from
Mar 21, 2023
Merged

[Many] i123017 integration annotation documentation #3495

merged 3 commits into from
Mar 21, 2023

Conversation

reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Mar 20, 2023 •
edited
Loading

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • [ x I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker reidbaker changed the title i123017 integration annotation documentation [Many] i123017 integration annotation documentation Mar 20, 2023
@reidbaker reidbaker added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Mar 20, 2023
@reidbaker reidbaker marked this pull request as ready for review March 20, 2023 17:23
stuartmorgan
stuartmorgan approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(FYI this shouldn't need the override label; anything in androidTest should be exempt automatically, and if it's not it's a tooling bug.)

@reidbaker reidbaker removed the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Mar 20, 2023
@reidbaker
Copy link
Contributor Author

LGTM

(FYI this shouldn't need the override label; anything in androidTest should be exempt automatically, and if it's not it's a tooling bug.)

AH, removed.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 20, 2023

auto label is removed for flutter/packages, pr: 3495, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 7528041 into flutter:main Mar 21, 2023
@reidbaker reidbaker deleted the i123017-integration-annotation-documentation branch March 21, 2023 14:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
@engine-flutter-autoroll
7528041 [Many] i123017 integration annotation documentation (flutter/…
2d88cba 
…packages#3495)
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@reidbaker @nploi
[Many] i123017 integration annotation documentation (flutter#3495)
9e9443f 
[Many] i123017 integration annotation documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartmorgan stuartmorgan stuartmorgan approved these changes

@tarrinneal tarrinneal tarrinneal approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 is a code owner

@gmackall gmackall Awaiting requested review from gmackall gmackall is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines is a code owner

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera p: espresso p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: path_provider p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidbaker @stuartmorgan @tarrinneal