Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigeon] add non-null type arguments #1225

Closed
wants to merge 6 commits into from

Conversation

gaaclarke
Copy link
Member

Turns out this was only meaningful for the Dart generator. That's why most of the work is in the Dart generator.

fixes flutter/flutter#97848

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke marked this pull request as ready for review March 16, 2022 00:10
@gaaclarke
Copy link
Member Author

Let me look into this a bit tomorrow. I'm think I can use a custom codec to encode Lists with non null values on the java and objc side to throw an exception if it finds a null value.

@gaaclarke gaaclarke marked this pull request as draft March 16, 2022 05:17
@gaaclarke gaaclarke removed the request for review from stuartmorgan March 16, 2022 05:17
@gaaclarke
Copy link
Member Author

Because of the null-safe limitation in ObjC and Java this PR has been stalled indefinitely. For example, you can't put nullability tags for types in type arguments to generic containers in ObjC or Java. I haven't found a good path forward and am not sure I recommend attempting it until we support kotlin and swift.

@gaaclarke gaaclarke closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant