Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointer_interceptor] fix integration test #1675

Merged
merged 5 commits into from
Apr 30, 2022

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Apr 29, 2022

The pointer interceptor test was probing into some implementation details of the web engine. As of flutter/engine#32712, the implementation has changed such that the semantics tree now sits on top of the platform views. This PR fixes the test accordingly.

Bonus:

  • Test platform interceptor both with and without semantics enabled.
  • Also test hit testing the background element directly (i.e. not just the buttons).

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ditman
Copy link
Member

ditman commented Apr 29, 2022

We should have picked this up with our roller, but tests for this package were being skipped. Running tests within the example directory of a package in CI is now being tracked here:

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@ditman
Copy link
Member

ditman commented Apr 29, 2022

publishable was failing because this PR was modifying the main.dart of the example (which is published in pub.dev here). Bumped patch version so this PR can be published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants