Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_plugin_tools] Support example/test/ in test command #102845

Closed
stuartmorgan opened this issue Apr 29, 2022 · 4 comments · Fixed by flutter/plugins#5453
Closed

[flutter_plugin_tools] Support example/test/ in test command #102845

stuartmorgan opened this issue Apr 29, 2022 · 4 comments · Fixed by flutter/plugins#5453
Labels
c: new feature Nothing broken; request for a new capability p: tooling Affects the flutter_plugin_tools package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels.

Comments

@stuartmorgan
Copy link
Contributor

Currently we're only running for <package>/test/; we should include all the examples as well so that examples can have their tests run. This is needed for some packages in flutter/packages, we actually have a couple in flutter/plugins that we aren't running, and as we adopt code-excerpt more we'll likely have more small tests of example code.
@stuartmorgan stuartmorgan added c: new feature Nothing broken; request for a new capability plugin p: tooling Affects the flutter_plugin_tools package P2 Important issues not at the top of the work list P1 High-priority issues at the top of the work list and removed P2 Important issues not at the top of the work list labels Apr 29, 2022
@chunhtai
Copy link
Contributor

Is the tool currently run flutter drive? if not we should probably add it too, the pointer_interceptor/example tests are driver tests

@stuartmorgan
Copy link
Contributor Author

A different command (drive-examples) runs flutter driver tests. test should really be called something like dart-unit-test since it's specific to that.

@ditman ditman changed the title [flutter_pulgin_tools] Support example/test/ in test command [flutter_plugin_tools] Support example/test/ in test command Apr 29, 2022
This was referenced Apr 29, 2022
Closed
Merged
@stuartmorgan
Copy link
Contributor Author

stuartmorgan commented Apr 29, 2022 •
edited

I filed #102851. The lack of driver tests is just a CI config issue.

stuartmorgan added a commit to stuartmorgan/plugins that referenced this issue Apr 30, 2022
@stuartmorgan
[flutter_plugin_tools] Include examples in test
41f3f2e 
Includes any Dart unit tests for examples when running Dart unit tests
via `test`.

Also updates the deprecated `dart pub run test` to `dart run test`.

Fixes flutter/flutter#102845
@stuartmorgan stuartmorgan mentioned this issue Apr 30, 2022
Merged
11 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
c: new feature Nothing broken; request for a new capability p: tooling Affects the flutter_plugin_tools package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flutter_plugin_tools] Include examples in test stuartmorgan/plugins
2 participants
@stuartmorgan @chunhtai