-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Enable more tests in Cirrus #1726
Conversation
This brings the Cirrus configuration more in line with flutter/plugins, to reduce testing diffs between the two repositories: - Updates naming and grouping comments to match flutter/plugins to make them easier to compare. - Enables building examples on all platforms. This was being done for Android, and iOS, and Windows, but not Linux, macOS, or web, which wasn't an intentional mismatch. - Enables 'flutter drive' tests for web. - Does not enable them for other platforms as currently there is no need for them, and setup is non-trivial on some platforms (FTL secrets for Android, new Dockerfile dependencies for Linux). - Enables native unit tests for all platforms. (In practice this is a no-op at the momement, but it's a very fast no-op that doesn't require extra setup.) Rolls repo tooling forward to pick up support for `drive-examples` in non-plugin packages, and for running Dart unit tests in examples. Fixes flutter/flutter#102851
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
@yjbanov @ditman Can the recent change to |
Checking. |
(Note that we've marked this test as |
Hacky tweak that should enable this, here: (I can push those changes into this branch, so we can land both at once?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI passes here, let's merge this so we get more testing going!
This pull request is not suitable for automatic merging in its current state.
|
/cc @stuartmorgan it seems the tool is not picking up updates to the PR text? |
You have to re-push after updating the PR text; there's some sort of cache of the description happening at the GitHub or Cirrus level if you just re-run. It's super annoying. |
Argh, I added an unnecessary CHANGELOG entry then. Luckily we'll be able to remove it when we undo the code. Thanks for the info! |
This brings the Cirrus configuration more in line with flutter/plugins,
to reduce testing diffs between the two repositories:
them easier to compare.
Android, and iOS, and Windows, but not Linux, macOS, or web, which
wasn't an intentional mismatch.
need for them, and setup is non-trivial on some platforms (FTL
secrets for Android, new Dockerfile dependencies for Linux).
no-op at the moment, but it's a very fast no-op that doesn't
require extra setup.)
These CI configurations come almost directly from flutter/plugins.
Supporting changes:
drive-examples
innon-plugin packages, and for running Dart unit tests in examples.
install_chromium.sh
script from flutter/plugins tosupport web
drive-examples
, and moves the existing version forbenchmarks to a different name with a TODO to merge them.
rfw/example/wasm
sothat CI doesn't try to build them.
flutter_markdown
'sLinux example, which came from an old template, as we no longer
tell people to install those libraries in our documentation.
Fixes flutter/flutter#102851
No CHANGELOG change: The tweaked tests in
pointer_interceptor
don't need a CHANGELOG entry, since that's temporary code that will be removed once the current fluttermaster
rolls intostable
.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).