Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder] Update to go_router 6 #2977

Merged
merged 3 commits into from Jan 4, 2023

Conversation

ValentinVignal
Copy link
Contributor

List which issues are fixed by this PR. You must list at least one issue.

No issue but this is a follow up to #2848

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above. I listed the related PR instead
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@ValentinVignal
Copy link
Contributor Author

I believe this PR can have a test exemption? Am I correct?

@chunhtai
Copy link
Contributor

This migrates go_router_builder due to go_router v6 breaking changes. The existing test should be good enough.

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to regenerate the example/ in order to pass the ci

@ValentinVignal
Copy link
Contributor Author

You will need to regenerate the example/ in order to pass the ci

I didn't modify any code of go_router_builder so the generated files shouldn't have changed, right? 🤔 Anyway, I tried re-generated them and I don't have any changes.
Plus, on dart_unit_tests CHANNEL:stable, the fails on /example/test/ensure_build_test.dart. The differences are on the pubspec.yaml so I'm not sure I understand what is happening 🤔 (The test is passing on my local)

@chunhtai
Copy link
Contributor

ah it is the path override that causes the test to fail, it is not related to this change, sorry about the confusion. I will put up a pr to fix it.

@chunhtai
Copy link
Contributor

This should fix it #2984

@Hixie
Copy link
Contributor

Hixie commented Dec 20, 2022

test-exempt: rolling dependencies

@chunhtai
Copy link
Contributor

The pr was merged. Can you rebase off the main branch and see if that fixes ci

@chunhtai
Copy link
Contributor

it looks like your branch is still missing the latest commit 73637b8

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 21, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 21, 2022

auto label is removed for flutter/packages, pr: 2977, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 21, 2022

auto label is removed for flutter/packages, pr: 2977, due to Validations Fail.

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2022
@chunhtai chunhtai merged commit 5773a70 into flutter:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router_builder
Projects
None yet
4 participants