New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go_router_builder] Update to go_router
6
#2977
[go_router_builder] Update to go_router
6
#2977
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I believe this PR can have a test exemption? Am I correct? |
This migrates go_router_builder due to go_router v6 breaking changes. The existing test should be good enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to regenerate the example/ in order to pass the ci
I didn't modify any code of |
ah it is the path override that causes the test to fail, it is not related to this change, sorry about the confusion. I will put up a pr to fix it. |
This should fix it #2984 |
test-exempt: rolling dependencies |
The pr was merged. Can you rebase off the main branch and see if that fixes ci |
81d8dad
to
b88d526
Compare
it looks like your branch is still missing the latest commit 73637b8 |
b88d526
to
c5863d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/packages, pr: 2977, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
auto label is removed for flutter/packages, pr: 2977, due to Validations Fail. |
List which issues are fixed by this PR. You must list at least one issue.
No issue but this is a follow up to #2848
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
I listed at least one issue that this PR fixes in the description above.I listed the related PR insteadpubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.