Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go_router_builder] Add go_router v5 support to go_router_builder #111909

Closed
chunhtai opened this issue Sep 19, 2022 · 10 comments · Fixed by flutter/packages#3439
Closed

[go_router_builder] Add go_router v5 support to go_router_builder #111909

chunhtai opened this issue Sep 19, 2022 · 10 comments · Fixed by flutter/packages#3439
Assignees
Labels
customer: crowd Affects or could affect many people, though not necessarily a specific customer. p: go_router_builder The go_router_builder package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels.

Comments

@chunhtai
Copy link
Contributor

go_router_builder should support new feature added into go_router_v5

These include

  • shellRoute API
  • async and buildcontext redirect.
@hawkkiller
Copy link

@chunhtai made PR flutter/packages#2672

@chunhtai
Copy link
Contributor Author

@hawkkiller thanks!

@chunhtai chunhtai assigned hawkkiller and unassigned chunhtai Oct 14, 2022
@johnpryan johnpryan changed the title [go_router_builder] go_router_builder should support go_router v5 [go_router_builder] Add go_router v5 support to go_router_builder Oct 26, 2022
@ClaireDavis
Copy link
Contributor

Do we have any idea on when this might be supported? I'd love to start using shell routes in my enterprise app!

@lucavenir
Copy link

Will this also introduce a way to write redirect methods inside ShellRouteData? Or is it already possible to define a redirect function on shell routes?

@thipokch
Copy link

Maybe bump this up to v6?

@adamsowinski
Copy link

This is a show stopper for using go_router_builder for me.

@ClaireDavis
Copy link
Contributor

Looks like this is complete? flutter/packages#2977

@lucavenir
Copy link

lucavenir commented Jan 25, 2023

@ClaireDavis no it isn't; this is also about ShellRoute which - to my knowledge - isn't available to the builder. Or at least I can't find it in the docs. GoRouteData has no "shell route" option.

@ycherniavskyi
Copy link
Contributor

@ClaireDavis, as @lucavenir wrote, it isn't for sure. We hope to switch to go_router_builder after mentioned PR merged, but unfortunately not. That is why for now, go_router_builder is useless if you want to get all go_router functionality.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
customer: crowd Affects or could affect many people, though not necessarily a specific customer. p: go_router_builder The go_router_builder package P3 Issues that are less important to the Flutter project package flutter/packages repository. See also p: labels.
Projects
No open projects
Status: Done
9 participants