[flutter_adaptive_scaffold] Fix leading Navigation Rail Widgets #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
The linux-build_all_packages failed due to:
Is there a way to re-run this check? |
…Widgets The leading and trailing Navigation Rail widgets were not being passed through to the Navigation Rail. Fixes flutter/flutter#114684
|
CLA accepted! I also updated the patch to include a fix for the trailing widget which should resolve all of flutter/flutter#114684. |
gspencergoog
added
the
autosubmit
sybrands-place
pushed a commit
to sybrands-place/packages
that referenced
this pull request
Jan 30, 2023
* main: (479 commits) removes raw ArrayLists (flutter#3101) Roll Flutter from c9affdba9dcd to 27f8ebdaed70 (15 revisions) (flutter#3098) [ci] Fix the new LUCI iOS build-all tasks (flutter#3099) [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100) [pigeon] Swift host error handling (flutter#3084) Roll Flutter from a815ee634202 to c9affdba9dcd (23 revisions) (flutter#3093) [ci] Enable min SDK version checks (flutter#3095) [pigeon] Fix C++ config handling (flutter#3094) [ci] Add LUCI version of iOS build-all (flutter#3096) [pigeon] Adds SwiftFunction annotation (flutter#2304) [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088) [pigeon] requires analyzer 5.2.0 (flutter#3090) Roll Flutter from c35efdaa6854 to a815ee634202 (22 revisions) (flutter#3089) [ci] Update legacy Flutter version tests (flutter#3087) Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086) [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080) Roll Flutter from bd7bee0f9eb8 to c35efdaa6854 (24 revisions) (flutter#3085) [pigeon] Minor C++ output adjustments (flutter#3083) [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081) Roll Flutter from f33e8d3701b5 to bd7bee0f9eb8 (5 revisions) (flutter#3082) ...
Maatteogekko
pushed a commit
to Maatteogekko/packages
that referenced
this pull request
Feb 4, 2023
…Widgets (flutter#3080) The leading and trailing Navigation Rail widgets were not being passed through to the Navigation Rail. Fixes flutter/flutter#114684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The leading Navigation Rail widgets were not being passed through to the Navigation Rail. This PR passes through the leading widget and adds a test to verify that the leading widget is displayed correctly based on the screen size.
Fixes flutter/flutter#114684
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).