-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Enable min SDK version checks #3095
[ci] Enable min SDK version checks #3095
Conversation
@@ -6,7 +6,7 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+ | |||
version: 1.0.5 | |||
|
|||
environment: | |||
sdk: ">=2.12.0 <3.0.0" | |||
sdk: ">=2.17.0 <3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could support arbitrarily old versions here since there's no Dart code, but building special casing in the tool to override the check just to allow new versions of this package to support really old versions of Flutter doesn't seem worthwhile.
You've angered the analyzer and repo check gods |
|
Oh nice, we can use |
* main: (479 commits) removes raw ArrayLists (flutter#3101) Roll Flutter from c9affdba9dcd to 27f8ebdaed70 (15 revisions) (flutter#3098) [ci] Fix the new LUCI iOS build-all tasks (flutter#3099) [pigeon] [ObjC] Removes unused GetNullableObject function (flutter#3100) [pigeon] Swift host error handling (flutter#3084) Roll Flutter from a815ee634202 to c9affdba9dcd (23 revisions) (flutter#3093) [ci] Enable min SDK version checks (flutter#3095) [pigeon] Fix C++ config handling (flutter#3094) [ci] Add LUCI version of iOS build-all (flutter#3096) [pigeon] Adds SwiftFunction annotation (flutter#2304) [flutter_adaptive_scaffold] Change `selectedIndex` on `standardNavigationRail` to allow null value. (flutter#3088) [pigeon] requires analyzer 5.2.0 (flutter#3090) Roll Flutter from c35efdaa6854 to a815ee634202 (22 revisions) (flutter#3089) [ci] Update legacy Flutter version tests (flutter#3087) Roll Flutter (stable) from 135454af3247 to b06b8b271095 (2551 revisions) (flutter#3086) [flutter_adaptive_scaffold] Fix leading and trailing Navigation Rail Widgets (flutter#3080) Roll Flutter from bd7bee0f9eb8 to c35efdaa6854 (24 revisions) (flutter#3085) [pigeon] Minor C++ output adjustments (flutter#3083) [pigeon] Updates writeScoped and addScoped to disallow symbol-less use. (flutter#3081) Roll Flutter from f33e8d3701b5 to bd7bee0f9eb8 (5 revisions) (flutter#3082) ...
* [cross_file] Fix accidental constructor change In #3095 I accidentally changed a constructor argument's nullability because of a misleading analyzer warning. That version has been retracted; this restores the original behavior. * Add a test * Better implementation
* Roll tool version * Enable new check in CI * Fix violations * CHANGELOG updates * Fix changelog * Address analyzer issues * Revert flutter_lints changelog
* [cross_file] Fix accidental constructor change In flutter#3095 I accidentally changed a constructor argument's nullability because of a misleading analyzer warning. That version has been retracted; this restores the original behavior. * Add a test * Better implementation
Rolls the repository tools forward to 0.13.4 and enables the new repo checks that no package claims to support an older version than the legacy analyzer tests are validating, since we have no idea if they actually work.
Updates packages as necessary to fix violations (those that didn't have a Flutter SDK constraint at all, since those were caught in the legacy test update).
This deliberately does not update any package versions, since we don't want to actively publish this change, only have it apply to future releases.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).