[path_provider_foundation] Adding support for getContainerPath on iOS #7114 #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/path_provider/path_provider_foundation/lib/path_provider_foundation.dart
Outdated
Show resolved
Hide resolved
packages/path_provider/path_provider_foundation/lib/path_provider_platform_provider.dart
Outdated
Show resolved
Hide resolved
packages/path_provider/path_provider_foundation/test/path_provider_foundation_test.dart
Outdated
Show resolved
Hide resolved
packages/path_provider/path_provider_foundation/test/path_provider_foundation_test.dart
Outdated
Show resolved
Hide resolved
|
@hellohuanlin would you take this review over? |
hellohuanlin
approved these changes
Mar 14, 2023
packages/path_provider/path_provider_foundation/example/ios/Runner.xcodeproj/project.pbxproj
Show resolved
Hide resolved
packages/path_provider/path_provider_foundation/lib/path_provider_foundation.dart
Show resolved
Hide resolved
stuartmorgan
approved these changes
Mar 14, 2023
packages/path_provider/path_provider_foundation/lib/path_provider_foundation.dart
Show resolved
Hide resolved
packages/path_provider/path_provider_foundation/test/path_provider_foundation_test.dart
Show resolved
Hide resolved
leighajarett
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2023
10 tasks
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…lutter#7114 (flutter#3450) [path_provider_foundation] Adding support for getContainerPath on iOS flutter#7114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method getContainerPath in the path_provider_foundation plugin, which returns the path to the container for a given App Group. It uses the getContainerUrl API.
This is only implemented for iOS, since App Groups works a bit differently on macOS.
Issue fixed: flutter/flutter#117685
This was recreated from a PR on the plugins repo: flutter/plugins#7114
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).