Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_wkwebview] Remove unnecessary cast #3971

Closed
wants to merge 2 commits into from

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented May 12, 2023

This is causing an internal build to fail as it has the unnecessary_cast lint enabled.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jiahaog jiahaog marked this pull request as ready for review May 16, 2023 06:26
@jiahaog jiahaog requested a review from cyanglaz as a code owner May 16, 2023 06:26
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a generated file by pigeon. Im not sure if we should edit it directly. (Probably shouldn't by looking at the comment at the beginning of the file)

cc @stuartmorgan

@stuartmorgan
Copy link
Contributor

Yes, any manual edits to this file will be destroyed the next time anyone touches the plugin.

The way to fix this would be a Pigeon PR to either

  • Remove the unnecessary cast in the generated code, or
  • Add that lint to the suppressions at the top of the file

then do a PR for webview_flutter to update Pigeon.

@jiahaog
Copy link
Member Author

jiahaog commented May 18, 2023

Thanks! I'll close this first until we have time to follow up

@jiahaog jiahaog closed this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants