Updated rfw/test/material_widgets_test.dart for M3 #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
HansMuller
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 27, 2023
flutter/packages@6b70804...f89ce02 2023-06-27 hansmuller@google.com Updated rfw/test/material_widgets_test.dart for M3 (flutter/packages#4316) 2023-06-27 tarrinneal@gmail.com [shared_preferences] Adds new `clearWithParameters` and `getAllWithParameters` methods to platform interface. (flutter/packages#4261) 2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter from 042c036 to 96a2c05 (60 revisions) (flutter/packages#4313) 2023-06-26 10687576+bparrishMines@users.noreply.github.com [file_selector_android] Create initial Android implementation of the file_selector package (flutter/packages#3814) 2023-06-26 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.json:json from 20230227 to 20230618 in /packages/in_app_purchase/in_app_purchase/example/android/app (flutter/packages#4244) 2023-06-26 me@ghyeok.io [webview_flutter_wkwebview] Adds the `isInspectable` to `WebKitWebViewController`. (flutter/packages#3984) 2023-06-26 stuartmorgan@google.com [ci] Remove jcenter from legacy project (flutter/packages#4306) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HansMuller
added a commit
to flutter/tests
that referenced
this pull request
Jun 27, 2023
Updated the flutter_packages hash to bring in a change that will allow ThemeData.useMaterial3's default to become true. See flutter/packages#4316
This was referenced Jul 7, 2023
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The appearance of the golden image created by the rfw
'Material widgets'test depends on the Material2 theme, which is currently the default theme. Updated the test to ensure that the test continues to succeed when the default theme is changed to Material3.See flutter/flutter#127064