[file_selector] Endorse Android #4329
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -53,6 +53,7 @@ packages/**/*_web/** @ditman | |||
| packages/camera/camera_android/** @camsim99 | |||
| packages/camera/camera_android_camerax/** @camsim99 | |||
| packages/espresso/** @reidbaker | |||
| packages/file_selector/file_selector_android/** @gmackall | |||
There was a problem hiding this comment.
@gmackall FYI I added you as the owner; we forgot to set an owner when we landed the implementation initially. Since it's similar to image_picker in structure, you seemed like the natural choice, but let me know if you'd rather someone else owns it.
There was a problem hiding this comment.
That makes sense, I'm fine with taking it on!
There was a problem hiding this comment.
Do we need a local .gitignore?
There was a problem hiding this comment.
It's part of the template; in general I have been keeping those.
Someday, when we have fixed all platforms to put new ignored files in directory that's already ignored instead of adding to a list of explicit files, I want to update this repo to not use the root ignore as a replacement for package-level ignores.
|
test-exempt: configuration change, adds more test |
stuartmorgan
added
the
autosubmit
flutter/packages@53ed5a0...cdae854 2023-07-01 engine-flutter-autoroll@skia.org Roll Flutter from ff838bc to aa5f4a2 (29 revisions) (flutter/packages#4363) 2023-07-01 stuartmorgan@google.com [tool] Add a flag to skip cleanup (flutter/packages#4357) 2023-07-01 stuartmorgan@google.com [file_selector] Endorse Android (flutter/packages#4329) 2023-07-01 stuartmorgan@google.com [google_sign_in] Convert Android to Pigeon (flutter/packages#4344) 2023-06-30 tarrinneal@gmail.com [Pigeon] readme updates (flutter/packages#3705) 2023-06-30 43054281+camsim99@users.noreply.github.com [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332) 2023-06-30 kustermann.martin@gmail.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342) 2023-06-30 tarrinneal@gmail.com [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794) 2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter from 51bef1b to ff838bc (12 revisions) (flutter/packages#4346) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Endorses the new Android implementation of
file_selector, updating the README accordingly.Also adjusts the example to better handle platform diffs, by hiding UI that doesn't work instead of just labelling it on the button. Left a TODO to improve how we determine what to hide once we have the API to do so.
Fixes flutter/flutter#110098
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).