-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfw] Restore RFW to 100% coverage #4355
Conversation
What about the code changes in text.dart? |
That's the dead code removal. Shouldn't affect anything. (It removes the unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit.
packages/rfw/CHANGELOG.md
Outdated
@@ -1,3 +1,7 @@ | |||
## NEXT | |||
|
|||
* Add more testing to restore coverage to 100%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Adds
(Per repo style guide.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternately you could omit the CHANGELOG since it's a dev-only change (modulo the production code removal, but you're not mentioning that part anyway).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Blocked on the flutter/flutter autoroll (#4415) which is blocked on the tree breakage. |
i guess mac arm64 coverage is broken... |
oh, no, the problem is that the way I made it skip goldens meant we were skipping a different amount of code for different platforms. Change it to skipping on the expects instead. |
Fixes flutter/flutter#106205 by regenerating goldens.
flutter/packages@2508714...aa1eace 2023-07-13 ian@hixie.ch [rfw] Restore RFW to 100% coverage (flutter/packages#4355) 2023-07-12 65381000+raju8000@users.noreply.github.com [file_selector_web] Listens to file input cancel event. (flutter/packages#3683) 2023-07-12 sam.rawlins@gmail.com [cross_file] Correct sorting of import starting with dot-slash (flutter/packages#4449) 2023-07-12 ian@hixie.ch [metrics_center] Remove Equatable dependency (flutter/packages#4444) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter from 3ec96a8 to 544d30d (66 revisions) (flutter/packages#4448) 2023-07-12 stuartmorgan@google.com [ci] Move snippet checks to LUCI (flutter/packages#4446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@2508714...aa1eace 2023-07-13 ian@hixie.ch [rfw] Restore RFW to 100% coverage (flutter/packages#4355) 2023-07-12 65381000+raju8000@users.noreply.github.com [file_selector_web] Listens to file input cancel event. (flutter/packages#3683) 2023-07-12 sam.rawlins@gmail.com [cross_file] Correct sorting of import starting with dot-slash (flutter/packages#4449) 2023-07-12 ian@hixie.ch [metrics_center] Remove Equatable dependency (flutter/packages#4444) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter from 3ec96a8 to 544d30d (66 revisions) (flutter/packages#4448) 2023-07-12 stuartmorgan@google.com [ci] Move snippet checks to LUCI (flutter/packages#4446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#106205 by regenerating goldens.
This is a follow-up to #2493.
This won't work until flutter/flutter#129851 lands and rolls into this repo.
I ran a script that I use to remove trailing spaces in the wrong directory and it cleaned up a couple of other files. The changes seem harmless so I left them in.
As this is only adding tests, this does not require a new version.
Adding tests found two bugs; one, there was a dead code branch in the tokenizer (code is now removed), and two, it found a bug in the framework (see link to PR above).
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).