Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate golden files for flutter/packages tests rfw and others #106205

Closed
jonahwilliams opened this issue Jun 17, 2022 · 4 comments · Fixed by flutter/packages#4355
Closed

Regenerate golden files for flutter/packages tests rfw and others #106205

jonahwilliams opened this issue Jun 17, 2022 · 4 comments · Fixed by flutter/packages#4355
Assignees
@Hixie
Labels
p: rfw Remote Flutter Widgets package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team waiting for PR to land (fixed) A fix is in flight

Comments

@jonahwilliams
Copy link
Member

These are currently disabled because of pixel snapping changes in the engine
@jonahwilliams jonahwilliams self-assigned this Jun 17, 2022
@jonahwilliams jonahwilliams added P1 High-priority issues at the top of the work list team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jun 17, 2022
@jonahwilliams

This comment was marked as outdated.

Sign in to view
This was referenced Jun 17, 2022
Merged
Merged
Closed
@jonahwilliams
Copy link
Member Author

Everything is added back, but rfw golden tests are still disabled

@Hixie
Copy link
Contributor

Hixie commented Nov 10, 2022

What's the story with the rfw goldens here?

@darshankawar darshankawar added the package flutter/packages repository. See also p: labels. label Jan 24, 2023
@Hixie Hixie assigned Hixie and unassigned jonahwilliams Jun 30, 2023
@Hixie Hixie added waiting for PR to land (fixed) A fix is in flight p: rfw Remote Flutter Widgets package labels Jun 30, 2023
Hixie added a commit to Hixie/packages that referenced this issue Jun 30, 2023
@Hixie
Restore RFW to 100% coverage
182bd95 
Fixes flutter/flutter#106205 by regenerating goldens.
Hixie added a commit to Hixie/packages that referenced this issue Jun 30, 2023
@Hixie
Restore RFW to 100% coverage
77a4a04 
Fixes flutter/flutter#106205 by regenerating goldens.
@Hixie Hixie mentioned this issue Jun 30, 2023
Merged
11 tasks
@flutter-triage-bot flutter-triage-bot bot added team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels Jul 8, 2023
Hixie added a commit to Hixie/packages that referenced this issue Jul 11, 2023
@Hixie
Restore RFW to 100% coverage
d3ec177 
Fixes flutter/flutter#106205 by regenerating goldens.
Hixie added a commit to Hixie/packages that referenced this issue Jul 12, 2023
@Hixie
Restore RFW to 100% coverage
2e9b262 
Fixes flutter/flutter#106205 by regenerating goldens.
Hixie added a commit to Hixie/packages that referenced this issue Jul 13, 2023
@Hixie
Restore RFW to 100% coverage
d60fad6 
Fixes flutter/flutter#106205 by regenerating goldens.
Hixie added a commit to Hixie/packages that referenced this issue Jul 13, 2023
@Hixie
Restore RFW to 100% coverage
bcf1f46 
Fixes flutter/flutter#106205 by regenerating goldens.
Hixie added a commit to Hixie/packages that referenced this issue Jul 13, 2023
@Hixie
Restore RFW to 100% coverage
e01cd81 
Fixes flutter/flutter#106205 by regenerating goldens.
auto-submit bot pushed a commit to flutter/packages that referenced this issue Jul 13, 2023
@Hixie
[rfw] Restore RFW to 100% coverage (#4355)
aa1eace 
Fixes flutter/flutter#106205 by regenerating goldens.

This is a follow-up to #2493.

This won't work until flutter/flutter#129851 lands and rolls into this repo.

I ran a script that I use to remove trailing spaces in the wrong directory and it cleaned up a couple of other files. The changes seem harmless so I left them in.

As this is only adding tests, this does not require a new version.

Adding tests found two bugs; one, there was a dead code branch in the tokenizer (code is now removed), and two, it found a bug in the framework (see link to PR above).
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Hixie Hixie

Labels
p: rfw Remote Flutter Widgets package P1 High-priority issues at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-ecosystem Owned by Ecosystem team triaged-ecosystem Triaged by Ecosystem team waiting for PR to land (fixed) A fix is in flight
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rfw] Restore RFW to 100% coverage Hixie/packages
3 participants
@Hixie @jonahwilliams @darshankawar