-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Add LUCI version of Android FTL tests in bringup mode #4571
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
.ci.yaml
Outdated
@@ -464,6 +464,70 @@ targets: | |||
{"dependency": "android_virtual_device", "version": "33"} | |||
] | |||
|
|||
# Device versions of Android integration tests, run via FTL. | |||
# TODO(stuartmorgan): Revisit whether we want these once we have more data | |||
# about emulator tests; see https://github.com/flutter/flutter/issues/131429. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think we should be more specific for our future selves. "Revisit if physical device tests are redundant once we have more data about emulator tests;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds new LUCI versions of the Android FTL tests. These are new tasks, rather than being part of android_platform_tests, since those are already running the emulator version of the tests, and the combination is far too slow (unless we roughly double the number of shards anyway), and this lets us control the behavior separately (e.g., not running them on
stable
, and potentially making them post-submit only in the future).Adjusts the repo tooling to make the
gcloud auth
step optional, since that's handled automatically for us in the LUCI environment, and to make it less tightly coupled to the Cirrus configuration by removing those defaults from the tool.Part of flutter/flutter#114373
See also flutter/flutter#131429