[go_router_builder] support v10.0.0 go_router #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chunhtai
reviewed
Jul 28, 2023
| @@ -56,6 +56,6 @@ Future<void> main() async { | |||
| .trim() | |||
| .replaceAll('\r\n', '\n'); | |||
| expect(generated, equals(expectResult.replaceAll('\r\n', '\n'))); | |||
| }); | |||
| }, timeout: const Timeout(Duration(seconds: 100))); | |||
There was a problem hiding this comment.
I think the default is 30 seconds, is it running longer than that?
There was a problem hiding this comment.
yes,I added this to avoid timing out
chunhtai
approved these changes
Jul 28, 2023
hangyujin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/flutter
that referenced
this pull request
Aug 2, 2023
flutter/packages@10aab44...60e9a54 2023-07-30 engine-flutter-autoroll@skia.org Manual roll Flutter from c2b40ca to 1d44fbd (7 revisions) (flutter/packages#4592) 2023-07-29 engine-flutter-autoroll@skia.org Roll Flutter from e81907e to c2b40ca (24 revisions) (flutter/packages#4588) 2023-07-28 stuartmorgan@google.com [ci] Switch FTL to LUCI (flutter/packages#4583) 2023-07-28 jhy03261997@gmail.com [go_router_builder] support v10.0.0 go_router (flutter/packages#4578) 2023-07-28 engine-flutter-autoroll@skia.org Roll Flutter from dd9764e to e81907e (21 revisions) (flutter/packages#4582) 2023-07-28 stuartmorgan@google.com [ci] Add LUCI version of Android FTL tests in bringup mode (flutter/packages#4571) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #131189
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.