-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gis_web] Migrate to package:web. #5581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Dec 6, 2023
packages/google_identity_services_web/test/js_loader_tt_forbidden_test.dart
Outdated
Show resolved
Hide resolved
kevmoo
reviewed
Dec 6, 2023
packages/google_identity_services_web/test/js_loader_tt_custom_test.dart
Outdated
Show resolved
Hide resolved
kevmoo
reviewed
Dec 6, 2023
packages/google_identity_services_web/lib/src/js_interop/package_web_tweaks.dart
Show resolved
Hide resolved
kevmoo
approved these changes
Dec 6, 2023
srujzs
approved these changes
Dec 6, 2023
packages/google_identity_services_web/example/integration_test/js_interop_id_test.dart
Show resolved
Hide resolved
packages/google_identity_services_web/example/integration_test/js_interop_id_test.dart
Outdated
Show resolved
Hide resolved
packages/google_identity_services_web/example/integration_test/utils.dart
Outdated
Show resolved
Hide resolved
packages/google_identity_services_web/lib/src/js_interop/google_accounts_id.dart
Show resolved
Hide resolved
packages/google_identity_services_web/lib/src/js_interop/google_accounts_id.dart
Show resolved
Hide resolved
ditman
force-pushed
the
gis-web-sdk-to-pkg-web
branch
from
December 6, 2023 23:01
8a3970a
to
fe62794
Compare
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
ditman
force-pushed
the
gis-web-sdk-to-pkg-web
branch
from
December 7, 2023 01:39
8feab8b
to
0c1e1c3
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2023
flutter/packages@ca16173...15584a3 2023-12-07 ditman@gmail.com [gis_web] Migrate to package:web. (flutter/packages#5581) 2023-12-07 kevmoo@users.noreply.github.com Drop quiver usage in several packages (flutter/packages#5595) 2023-12-07 stuartmorgan@google.com [video_player] Unfork publish: for macOS (flutter/packages#5578) 2023-12-07 kevmoo@users.noreply.github.com [web_benchmarks] migrate to pkg:web (flutter/packages#5592) 2023-12-07 43054281+camsim99@users.noreply.github.com [animations] Bump minimum supported Dart version to 3.2 (flutter/packages#5598) 2023-12-06 43054281+camsim99@users.noreply.github.com [animations] Bump minimum Flutter version (flutter/packages#5596) 2023-12-06 6655696+guidezpl@users.noreply.github.com Migrate Material curves to new names (flutter/packages#4898) 2023-12-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[pointer_interceptor] Add ios implementation and move web implementation to federated structure" (flutter/packages#5591) 2023-12-06 louisehsu@google.com [pointer_interceptor] Add ios implementation and move web implementation to federated structure (flutter/packages#5500) 2023-12-06 stuartmorgan@google.com [pigeon] Use dart:io output inheritance for tooling (flutter/packages#5536) 2023-12-06 43759233+kenzieschmoll@users.noreply.github.com Fix benchmark reload bug and migrate away from deprecated `js_util` APIs (flutter/packages#5577) 2023-12-06 stuartmorgan@google.com [google_sign_in] Add macOS support (flutter/packages#4962) 2023-12-06 ian@hixie.ch [rfw,flutter_markdown] Apparently you need a comma to end an //ignore (flutter/packages#5582) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
HugoOlthof
pushed a commit
to moneybird/packages
that referenced
this pull request
Dec 13, 2023
* Migrates package to use `package:web` so it can be compiled with WASM. * **Breaking change**: Addresses API mismatches with the latest JS SDK changes. * Adds some tests to client configuration objects. (See CHANGELOG.md for a more thorough list of changes) ## Issues * Fixes: flutter/flutter#138202 * Fixes: flutter/flutter#139167 * Part of: flutter/flutter#139170 ## Tests * Ran unit/integration tests locally, added a couple more. * Tested example apps with `flutter run`, both seem to work. * Tested example apps with `--wasm`, both seem to work.
Closed
12 tasks
16 tasks
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
* Migrates package to use `package:web` so it can be compiled with WASM. * **Breaking change**: Addresses API mismatches with the latest JS SDK changes. * Adds some tests to client configuration objects. (See CHANGELOG.md for a more thorough list of changes) ## Issues * Fixes: flutter/flutter#138202 * Fixes: flutter/flutter#139167 * Part of: flutter/flutter#139170 ## Tests * Ran unit/integration tests locally, added a couple more. * Tested example apps with `flutter run`, both seem to work. * Tested example apps with `--wasm`, both seem to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package:web
so it can be compiled with WASM.(See CHANGELOG.md for a more thorough list of changes)
Issues
Tests
flutter run
, both seem to work.--wasm
, both seem to work.Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.