Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android #5996

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps androidx.webkit:webkit from 1.7.0 to 1.10.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@bparrishMines
Copy link
Contributor

This is still waiting on compileSdk version 34 update for the plugin. Which is waiting on fixing bugs caused by running tests on AVD 34: #5221

@stuartmorgan
Copy link
Contributor

This is still waiting on compileSdk version 34 update for the plugin. Which is waiting on fixing bugs caused by running tests on AVD 34: #5221

@camsim99 Why is updating compileSdk blocked on running on 34? A compileSdk 34 plugin should still run on any version we support.

@camsim99
Copy link
Contributor

This is still waiting on compileSdk version 34 update for the plugin. Which is waiting on fixing bugs caused by running tests on AVD 34: #5221

@camsim99 Why is updating compileSdk blocked on running on 34? A compileSdk 34 plugin should still run on any version we support.

My understanding is generally/was that it is higher priority for us to fix existing issues of the plugins running on devices running the newer version before updating the compileSdk version for compile against that newer version, but given webview_flutter is blocked on the former by what seems to be infra issues, I'm not sure that we should block that update. @reidbaker what do you think?

@reidbaker
Copy link
Contributor

This is still waiting on compileSdk version 34 update for the plugin. Which is waiting on fixing bugs caused by running tests on AVD 34: #5221

@camsim99 Why is updating compileSdk blocked on running on 34? A compileSdk 34 plugin should still run on any version we support.

My understanding is generally/was that it is higher priority for us to fix existing issues of the plugins running on devices running the newer version before updating the compileSdk version for compile against that newer version, but given webview_flutter is blocked on the former by what seems to be infra issues, I'm not sure that we should block that update. @reidbaker what do you think?

I think we should be able to update compileSdk even if we cant update what versions of android the app runs on. In general our compile sdk should be the newest stable available.

That said @camsim99 I trust your judgement on the priority of this bug compared to the other work you have on your plate.

@stuartmorgan
Copy link
Contributor

I made #6106, and I'll see if it needs any additional intervention to be landable.

@stuartmorgan
Copy link
Contributor

@dependabot rebase

Bumps androidx.webkit:webkit from 1.7.0 to 1.10.0.

---
updated-dependencies:
- dependency-name: androidx.webkit:webkit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/packages/webview_flutter/webview_flutter_android/android/androidx.webkit-webkit-1.10.0 branch from 0e55e61 to 88aa697 Compare February 13, 2024 19:16
@goderbauer
Copy link
Member

I spoke to @bparrishMines last week and he told me that this is still on his radar.

Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

A newer version of androidx.webkit:webkit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

…adle/packages/webview_flutter/webview_flutter_android/android/androidx.webkit-webkit-1.10.0
Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label May 22, 2024
@auto-submit auto-submit bot merged commit 66530f2 into main May 23, 2024
74 checks passed
@auto-submit auto-submit bot deleted the dependabot/gradle/packages/webview_flutter/webview_flutter_android/android/androidx.webkit-webkit-1.10.0 branch May 23, 2024 03:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
… in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
… in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 23, 2024
… in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 23, 2024
flutter/packages@6525441...1008d9e

2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784)
2024-05-23 stuartmorgan@google.com [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755)
2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780)
2024-05-23 goderbauer@google.com [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
…r#148980)

flutter/packages@6525441...1008d9e

2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from 73bf206 to 8d955cd (24 revisions) (flutter/packages#6786)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 5dcb86f to a14f74f (3 revisions) (flutter/packages#6784)
2024-05-23 stuartmorgan@google.com [file_selector] Convert iOS to Swift and SPM (flutter/packages#6755)
2024-05-23 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.7.0 to 1.10.0 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#5996)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter from d02292d to 73bf206 (31 revisions) (flutter/packages#6780)
2024-05-23 goderbauer@google.com [rfw] Adds support for `DecorationImage.filterQuality`. (flutter/packages#6781)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
…ges/webview_flutter/webview_flutter_android/android (flutter#5996)

Bumps androidx.webkit:webkit from 1.7.0 to 1.10.0.

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=androidx.webkit:webkit&package-manager=gradle&previous-version=1.7.0&new-version=1.10.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App dependencies Pull requests that update a dependency file java Pull requests that update Java code p: webview_flutter platform-android
Projects
None yet
6 participants