[go_router_builder] Tweaks for latest analyzer-6.5.0 #6632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
added
warning: land on red to fix tree breakage
…ing between resolved versions.
|
test-exempt: rolling dependency |
|
(This needs to land on red to fix the broken tree) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 1, 2024
flutter/packages@cc47b06...aea93d2 2024-04-30 15619084+vashworth@users.noreply.github.com Skip podspec Swift Search Path validation if only swift file is Package.swift (flutter/packages#6627) 2024-04-30 ditman@gmail.com [go_router_builder] Tweaks for latest analyzer-6.5.0 (flutter/packages#6632) 2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter from db8c475 to b597dd2 (23 revisions) (flutter/packages#6631) 2024-04-30 44902066+waleedf112@users.noreply.github.com [flutter_adaptive_scaffold] use `MediaQuery.sizeOf` instead of `MediaQuery.of` to prevent unnecessary rebuilds (flutter/packages#6544) 2024-04-30 34871572+gmackall@users.noreply.github.com [image_picker] Update documentation to note that Photo Picker use is non-optional on Android 13+ (flutter/packages#6569) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
This PR slightly tweaks `go_router_builder` to work with `analyzer-6.5.0` and unblock post-submit [errors](https://github.com/flutter/packages/runs/24440595710). ## Issues * Should fix failing tests after this merge: flutter#6631
arc-yong
pushed a commit
to Arctuition/packages-arc
that referenced
this pull request
Jun 14, 2024
This PR slightly tweaks `go_router_builder` to work with `analyzer-6.5.0` and unblock post-submit [errors](https://github.com/flutter/packages/runs/24440595710). ## Issues * Should fix failing tests after this merge: flutter#6631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slightly tweaks
go_router_builderto work withanalyzer-6.5.0and unblock post-submit errors.Issues
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.