Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go_router_builder] Tweaks for latest analyzer-6.5.0 #6632

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[go_router_builder] Tweaks for latest analyzer-6.5.0 #6632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458917d
[go_router_builder] Tweaks for latest analyzer-6.5.0
ditman Apr 30, 2024
8b2af76
Ignores withNullability default value, because analyzer is flip-flopp…
ditman Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/go_router_builder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.6.1

* Fixes typo in `durationDecoderHelperName`.
* Updates development dependency to `dart_style-2.3.6` (compatible with `analyzer-6.5.0`).

## 2.6.0

* Adds support for passing observers to the StatefulShellBranch for the nested Navigator.
Expand Down
3 changes: 2 additions & 1 deletion packages/go_router_builder/lib/src/type_helpers.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const String convertMapValueHelperName = r'_$convertMapValue';

/// The name of the generated, private helper for converting [Duration] to
/// [bool].
const String durationDecoderHelperName = r'_$duractionConverter';
const String durationDecoderHelperName = r'_$durationConverter';

/// The name of the generated, private helper for converting [String] to [Enum].
const String enumExtensionHelperName = r'_$fromName';
Expand Down Expand Up @@ -91,6 +91,7 @@ String enumMapName(InterfaceType type) => '_\$${type.element.name}EnumMap';

String _stateValueAccess(ParameterElement element, Set<String> pathParameters) {
if (element.isExtraField) {
// ignore: avoid_redundant_argument_values
return 'extra as ${element.type.getDisplayString(withNullability: true)}';
}

Expand Down
4 changes: 2 additions & 2 deletions packages/go_router_builder/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: go_router_builder
description: >-
A builder that supports generated strongly-typed route helpers for
package:go_router
version: 2.6.0
version: 2.6.1
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22

Expand All @@ -23,7 +23,7 @@ dependencies:

dev_dependencies:
build_test: ^2.1.7
dart_style: 2.3.2
dart_style: 2.3.6
flutter:
sdk: flutter
go_router: ^10.0.0
Expand Down