-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[google_maps_flutter_web] Migrate to google_maps: 8.0.0
#7077
base: main
Are you sure you want to change the base?
[google_maps_flutter_web] Migrate to google_maps: 8.0.0
#7077
Conversation
Why are the integration tests skipped? Is it because other steps are failing? |
package:web
migrationgoogle_maps: 8.0.0
Because they are currently disabled @ditman FYI in case you aren't aware; maybe something you could look at while gardening? @bparrishMines That's assigned to you, are you actively working on it? We shouldn't leave whole tests suites disabled for extended periods if we can avoid it. |
@stuartmorgan Yea im going to take a look into it now. I'll try to narrow down the specific test to skip, so we no longer skip all the integration tests. |
@stuartmorgan is there an issue to track running integration tests compiled to WASM in CI? |
@@ -32,6 +32,12 @@ dev_dependencies: | |||
flutter_test: | |||
sdk: flutter | |||
|
|||
dependency_overrides: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll want to drop this override, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely
We also likely DON'T want to publish this package depending on a pre-release package. |
Also definitely the case |
@ditman would probably be the best person to answer this; I'm not sure what the current plans are around wasm support and testing for plugins. |
I created flutter/flutter#151664 to track running web integration tests compiled to WASM |
Migrates
google_maps_flutter_web
togoogle_maps: ^8.0.0
Blocked on the following:
--wasm
flutter#151426flutter drive --wasm
does not report results even though tests completed flutter#151561Fixes flutter/flutter#148624