Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_maps_flutter_web] Migrate to google_maps: 8.0.0 #7077

Merged
merged 45 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
6014043
wip
kevmoo Jul 7, 2024
5a0a325
Merge remote-tracking branch 'upstream/main' into maps_haxs
Rexios80 Jul 7, 2024
84445f1
Working on migration
Rexios80 Jul 7, 2024
afb21bc
Remove unnecessary null checks
Rexios80 Jul 7, 2024
632c425
Regenerate mocks
Rexios80 Jul 8, 2024
6549ae9
Fixing issues
Rexios80 Jul 8, 2024
662a656
Fixing issues
Rexios80 Jul 8, 2024
009bde1
Fixing issues
Rexios80 Jul 8, 2024
9d3b749
Update index.html files
Rexios80 Jul 8, 2024
c886e30
Use google_maps from git for now
Rexios80 Jul 8, 2024
f630e78
Cleanup
Rexios80 Jul 8, 2024
8ed0567
Cleanup
Rexios80 Jul 8, 2024
8365be5
Fixing issues
Rexios80 Jul 8, 2024
1136718
Preparing for release
Rexios80 Jul 8, 2024
4596476
Use latest google_maps commit
Rexios80 Jul 9, 2024
b417e89
Use latest google_maps commit
Rexios80 Jul 10, 2024
a6562b1
Update exclude_all_packages_app_wasm.yaml
Rexios80 Jul 11, 2024
fa2f49d
Merge branch 'main' into google-maps-package-web-migration
Rexios80 Jul 13, 2024
e763d9d
Add `google_maps` dependency override to `google_maps_flutter` tempor…
Rexios80 Jul 13, 2024
1197527
Merge remote-tracking branch 'upstream/main' into google-maps-package…
Rexios80 Jul 18, 2024
0df349f
Merge remote-tracking branch 'upstream/main' into google-maps-package…
Rexios80 Jul 22, 2024
8468c52
Use new `google_maps` version and remove overrides
Rexios80 Jul 23, 2024
f6fb13c
Merge branch 'main' into google-maps-package-web-migration
Rexios80 Jul 23, 2024
a57c228
Merge remote-tracking branch 'upstream/main' into google-maps-package…
Rexios80 Jul 23, 2024
78df83d
Trigger events the same way as in google_maps_controller_test
ditman Jul 24, 2024
ef43166
Run assertions before accessing bounds and projection.
ditman Jul 24, 2024
c04ae22
Allow web:^1.0.0
ditman Jul 24, 2024
85f4037
Override git url from https instead of ssh.
ditman Jul 24, 2024
0ef12c7
Remove web:1.0.0 since the all_packages app still resolves to 0.5.
ditman Jul 24, 2024
560bda4
Support innerHTMLString through an extension, so the package works bo…
ditman Jul 24, 2024
924a000
Update CHANGELOG.md
ditman Jul 24, 2024
b9b2c04
Merge branch 'main' into google-maps-package-web-migration
Rexios80 Jul 25, 2024
fc4b1de
Merge branch 'main' into google-maps-package-web-migration
ditman Jul 25, 2024
c5488cb
Serve markerclusterer locally so wasm allows loading it.
ditman Jul 26, 2024
a3ca0c4
Convert JSString.toDart properly.
ditman Jul 26, 2024
dbb8847
Correctly read img.hidden in overlay_test.dart
ditman Jul 26, 2024
7d65249
Improve expect statement to match one below
Rexios80 Jul 26, 2024
0fb9b67
Read innerHTML correctly from markers_test.dart
ditman Jul 26, 2024
87063e0
Cast properties from JS Shapes correctly in shapes_test.dart
ditman Jul 26, 2024
3e48fb2
Access deeply nested JS property in styler correctly in google_maps_p…
ditman Jul 26, 2024
03d05db
User marerclusterer from a CDN compliant with COEP/CORP so it works i…
ditman Jul 26, 2024
b1c91bf
Bump to google_maps 8.0.0
ditman Jul 31, 2024
48e8b4c
Merge branch 'main' into google-maps-package-web-migration
ditman Jul 31, 2024
613065e
Bump to google_maps 8.0.0 in example
Rexios80 Jul 31, 2024
31e0a46
Merge remote-tracking branch 'upstream/main' into google-maps-package…
Rexios80 Jul 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,34 +33,13 @@
<link rel="icon" type="image/png" href="favicon.png"/>

<title>Google Maps Web Example</title>

<link rel="manifest" href="manifest.json">

<!-- This API key comes from: go/flutter-maps-web-tests-api-key (GCP project: flutter-infra) -->
<script src="https://maps.googleapis.com/maps/api/js?key=AIzaSyAa9cRBkhuxGq3Xw3HPz8SPwaVOhRmm7kk&libraries=geometry"></script>

<script>
// The value below is injected by flutter build, do not touch.
const serviceWorkerVersion = null;
</script>
<!-- This script adds the flutter initialization JS code -->
<script src="flutter.js" defer></script>
</head>
<body>
<script>
window.addEventListener('load', function(ev) {
// Download main.dart.js
_flutter.loader.loadEntrypoint({
serviceWorker: {
serviceWorkerVersion: serviceWorkerVersion,
},
onEntrypointLoaded: function(engineInitializer) {
engineInitializer.initializeEngine().then(function(appRunner) {
appRunner.runApp();
});
}
});
});
</script>
<script src="flutter_bootstrap.js" async></script>
</body>
</html>
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.5.9

* Updates `package:google_maps` dependency to latest (`^8.0.0`).

## 0.5.8

* Adds support for BitmapDescriptor classes `AssetMapBitmap` and `BytesMapBitmap`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,24 @@ import 'google_maps_controller_test.mocks.dart';
// LatLng values.
const String _kCloudMapId = '000000000000000'; // Dummy map ID.

gmaps.Map mapShim() => throw UnimplementedError();

@GenerateNiceMocks(<MockSpec<dynamic>>[
MockSpec<CirclesController>(),
MockSpec<PolygonsController>(),
MockSpec<PolylinesController>(),
MockSpec<MarkersController>(),
MockSpec<TileOverlaysController>(),
MockSpec<CirclesController>(
fallbackGenerators: <Symbol, Function>{#googleMap: mapShim},
),
MockSpec<PolygonsController>(
fallbackGenerators: <Symbol, Function>{#googleMap: mapShim},
),
MockSpec<PolylinesController>(
fallbackGenerators: <Symbol, Function>{#googleMap: mapShim},
),
MockSpec<MarkersController>(
fallbackGenerators: <Symbol, Function>{#googleMap: mapShim},
),
MockSpec<TileOverlaysController>(
fallbackGenerators: <Symbol, Function>{#googleMap: mapShim},
),
])

/// Test Google Map Controller
Expand Down Expand Up @@ -221,15 +233,15 @@ void main() {
late MockPolygonsController polygons;
late MockPolylinesController polylines;
late MockTileOverlaysController tileOverlays;
late gmaps.GMap map;
late gmaps.Map map;

setUp(() {
circles = MockCirclesController();
markers = MockMarkersController();
polygons = MockPolygonsController();
polylines = MockPolylinesController();
tileOverlays = MockTileOverlaysController();
map = gmaps.GMap(createDivElement());
map = gmaps.Map(createDivElement());
});

testWidgets('listens to map events', (WidgetTester tester) async {
Expand All @@ -246,19 +258,19 @@ void main() {
// Trigger events on the map, and verify they've been broadcast to the stream
final Stream<MapEvent<Object?>> capturedEvents = stream.stream.take(5);

gmaps.Event.trigger(
gmaps.event.trigger(
map,
'click',
<Object>[gmaps.MapMouseEvent()..latLng = gmaps.LatLng(0, 0)],
gmaps.MapMouseEvent()..latLng = gmaps.LatLng(0, 0),
);
gmaps.Event.trigger(
gmaps.event.trigger(
map,
'rightclick',
<Object>[gmaps.MapMouseEvent()..latLng = gmaps.LatLng(0, 0)],
gmaps.MapMouseEvent()..latLng = gmaps.LatLng(0, 0),
);
// The following line causes 2 events
gmaps.Event.trigger(map, 'bounds_changed', <Object>[]);
gmaps.Event.trigger(map, 'idle', <Object>[]);
gmaps.event.trigger(map, 'bounds_changed');
gmaps.event.trigger(map, 'idle');

final List<MapEvent<Object?>> events = await capturedEvents.toList();

Expand Down Expand Up @@ -539,12 +551,12 @@ void main() {
});
});

// These are the methods that are delegated to the gmaps.GMap object, that we can mock...
// These are the methods that are delegated to the gmaps.Map object, that we can mock...
group('Map control methods', () {
late gmaps.GMap map;
late gmaps.Map map;

setUp(() {
map = gmaps.GMap(
map = gmaps.Map(
createDivElement(),
gmaps.MapOptions()
..zoom = 10
Expand Down Expand Up @@ -604,7 +616,7 @@ void main() {

group('viewport getters', () {
testWidgets('getVisibleRegion', (WidgetTester tester) async {
final gmaps.LatLng gmCenter = map.center!;
final gmaps.LatLng gmCenter = map.center;
final LatLng center =
LatLng(gmCenter.lat.toDouble(), gmCenter.lng.toDouble());

Expand Down
Loading