[ci] Split build_all_packages by JDK version. #7106
Merged
+81
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
Closed by mistake, d'oh! |
ditman
changed the title
.ci.yaml
Outdated
| recipe: packages/packages | ||
| timeout: 30 | ||
| properties: | ||
| add_recipes_cq: "true" |
There was a problem hiding this comment.
I'm going to remove this from the PR; we were causing problems previously where our flake was messing up the recipes CQ because we'd put so many similar tests in it.
|
Thanks @stuartmorgan! Note that the web failures seems to be legit, for some reason the integration_tests are now attempting to run (with references to dart:io and a bunch of other no-nos), I'll post another PR shortly to fix the issue. Not sure how these tests didn't show up before in pre or post-submit :S |
stuartmorgan
added
the
autosubmit
|
(Autosubmit will probably fail on macOS flake, but it doesn't hurt to try!) |
|
auto label is removed for flutter/packages/7106, due to - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan
added
the
autosubmit
|
I'm just going to force land this; the macOS infra flake is brutal, and there's no mechanism by which this PR could break those tasks. |
stuartmorgan
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
|
Thanks for landing this @stuartmorgan! I was investigating this failure, that looks like a new web flake (it flakes on my local as well :/) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2024
flutter/packages@ea35fc6...3379e51 2024-07-12 stuartmorgan@google.com [pigeon] Fix C++ enum naming (flutter/packages#7094) 2024-07-12 ditman@gmail.com [ci] Split build_all_packages by JDK version. (flutter/packages#7106) 2024-07-12 41930132+hellohuanlin@users.noreply.github.com [ios]Fix compile error when conforming UIApplication to Launcher due to MainActor annotation (flutter/packages#7100) 2024-07-11 47866232+chunhtai@users.noreply.github.com [go_router] Makes GoRouterState lookup more robust. (flutter/packages#6920) 2024-07-11 mdebbar@google.com [ci][web] Run tests in canvaskit mode. (flutter/packages#6879) 2024-07-10 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/image_picker/image_picker_android/android (flutter/packages#6648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 13, 2024
This PR attempts to roll the `master` version of Flutter with a small CI tweak. ## [ci] Configures split `all_packages` build Continuing #7106: * Makes android_build_all_packages build with JDK17 only, and only a JDK17 project. * Gets android_build_all_packages_legacy out of bringup. This should resolve the [gradle issues](https://github.com/flutter/packages/pull/7098/checks?check_run_id=27296340933) of the "all_packages" app with the latest version of Flutter. ## Manual roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions) Same as this roll triggered by the roller: * #7110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
android_build_all_packages_legacyinmasterandstableto build only the "legacy" version of an Android project using JDK11.This PR is required to resume rolling the flutter framework, like here:
Moving forward,
android_build_all_packageswill use JDK17+ andandroid_build_all_packages_legacywill use JDK11, both inmasterandstable, instead of having an unified build.After this lands, the new tasks need to be taken out of
bringup:true, and the existingandroid_build_all_packagestasks need to point to the _jdk17.yaml configuration file that is being introduced in this PR.(The not suffixed
android_build_all_packages.yamlfile may be removed, or replaced with the contents of the _jdk17.yaml one!)Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.