[pigeon] Fix C++ enum naming #7094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ generator wasn't adjusting enum value names, so they were just using the Dart camelCase style. This makes them style-guide compliant by adding the `k` prefix and making the first actual letter upper-case. Fixes flutter/flutter#147328
|
This isn't time-sensitive; if you'd like to fold it into another breaking change to slow the version train down a bit, feel free. |
tarrinneal
approved these changes
Jul 12, 2024
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 12, 2024
flutter/packages@ea35fc6...3379e51 2024-07-12 stuartmorgan@google.com [pigeon] Fix C++ enum naming (flutter/packages#7094) 2024-07-12 ditman@gmail.com [ci] Split build_all_packages by JDK version. (flutter/packages#7106) 2024-07-12 41930132+hellohuanlin@users.noreply.github.com [ios]Fix compile error when conforming UIApplication to Launcher due to MainActor annotation (flutter/packages#7100) 2024-07-11 47866232+chunhtai@users.noreply.github.com [go_router] Makes GoRouterState lookup more robust. (flutter/packages#6920) 2024-07-11 mdebbar@google.com [ci][web] Run tests in canvaskit mode. (flutter/packages#6879) 2024-07-10 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.10.1 to 1.13.1 in /packages/image_picker/image_picker_android/android (flutter/packages#6648) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ generator wasn't adjusting enum value names, so they were just using the Dart camelCase style. This makes them style-guide compliant by adding the
kprefix and making the first actual letter upper-case.Fixes flutter/flutter#147328
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).