This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Change from Rectangle<num>/Point<num> to Rect/Offset for ui convenience #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
commented
Feb 6, 2019
| for (NSValue *point in points) { | ||
| [points addObject:@[ @(((__bridge CGPoint *)point)->x), @(((__bridge CGPoint *)point)->y) ]]; | ||
| for (NSValue *point in barcode.cornerPoints) { | ||
| [points addObject:@[ @(point.CGPointValue.x), @(point.CGPointValue.y) ]]; |
bparrishMines
commented
Feb 6, 2019
| for (NSValue *point in points) { | ||
| [points addObject:@[ @(((__bridge CGPoint *)point)->x), @(((__bridge CGPoint *)point)->y) ]]; | ||
| for (NSValue *point in cornerPoints) { | ||
| [points addObject:@[ @(point.CGPointValue.x), @(point.CGPointValue.y) ]]; |
| @@ -141,12 +140,12 @@ void main() { | |||
|
|
|||
| final Barcode barcode = barcodes[0]; | |||
| expect(barcode.valueType, BarcodeValueType.unknown); | |||
| expect(barcode.boundingBox, const Rectangle<int>(1, 2, 3, 4)); | |||
| expect(barcode.boundingBox, Rect.fromLTWH(1.0, 2.0, 3.0, 4.0)); | |||
There was a problem hiding this comment.
With implicit int -> conversion in Dart 2.1 could change to ints, unless backwards compatibility a requirement
There was a problem hiding this comment.
I think keeping backwards compatibility would be the best move.
The current version only requires 2.0.0 and upgrading to 2.1.0 might not be worth causing another breaking change. The only gain from using 2.1 would make the tests require slightly less code.
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
…onvenience (flutter#1163)" This reverts commit 12b8e48.
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
karantanwar
pushed a commit
to karantanwar/plugins
that referenced
this pull request
Feb 19, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a bug where iOS was not getting corner point results.