This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Minor bugfixes and code cleanup #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring split out from a future patch on querying the purchase
history.
file. I initially didn't put everything there because normally the
keystore file only has signing information. But the app ID, verison
name, and version code all do need to be potentially modified in the
example to get it up and running. They're not inherently sensitive
like the signing information is but it probably makes sense to keep
them out of source control for the plugin repo too.
BillingResponse
code.BillingClient#_callbacks
to be a map of lists insteadof a list of maps. The OnPurchasesUpdated() listener is a singleton
and we never really have a good opportunity to pass down a
handle
.It makes more sense to me to store these by name. Also deleted the
remove
code since it would causehandle
to be off for futureentries.
the UI slightly.