Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Minor bugfixes and code cleanup #1284

Merged
merged 1 commit into from
Feb 26, 2019
Merged

[in_app_purchase] Minor bugfixes and code cleanup #1284

merged 1 commit into from
Feb 26, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Feb 26, 2019

Some refactoring split out from a future patch on querying the purchase
history.

  1. Moved all Android app-specific information to the keystore.properties
    file. I initially didn't put everything there because normally the
    keystore file only has signing information. But the app ID, verison
    name, and version code all do need to be potentially modified in the
    example to get it up and running. They're not inherently sensitive
    like the signing information is but it probably makes sense to keep
    them out of source control for the plugin repo too.
  2. Fixed the MethodChannel argument naming for some of the new methods.
  3. Added a missing BillingResponse code.
  4. Changed the BillingClient#_callbacks to be a map of lists instead
    of a list of maps. The OnPurchasesUpdated() listener is a singleton
    and we never really have a good opportunity to pass down a handle.
    It makes more sense to me to store these by name. Also deleted the
    remove code since it would cause handle to be off for future
    entries.
  5. Fixed a concurrency issue on Android in the example app, and tweaked
    the UI slightly.

Some refactoring split out from a future patch on querying the purchase
history.

1. Moved all Android app-specific information to the keystore.properties
   file. I initially didn't put everything there because normally the
   keystore file only has signing information. But the app ID, verison
   name, and version code all do need to be potentially modified in the
   example to get it up and running. They're not inherently sensitive
   like the signing information is but it probably makes sense to keep
   them out of source control for the plugin repo too.
2. Fixed the MethodChannel argument naming for some of the new methods.
3. Added a missing `BillingResponse` code.
4. Changed the `BillingClient#_callbacks` to be a map of lists instead
   of a list of maps. The OnPurchasesUpdated() listener is a singleton
   and we never really have a good opportunity to pass down a `handle`.
   It makes more sense to me to store these by name. Also deleted the
   `remove` code since it would cause `handle` to be off for future
   entries.
5. Fixed a concurrency issue on Android in the example app, and tweaked
   the UI slightly.
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@mklim mklim merged commit 1003084 into flutter:master Feb 26, 2019
@mklim mklim deleted the iap_refactoring branch February 26, 2019 22:11
romaluca pushed a commit to romaluca/plugins that referenced this pull request Mar 6, 2019
Some refactoring split out from a future patch on querying the purchase
history.

1. Moved all Android app-specific information to the keystore.properties
   file. I initially didn't put everything there because normally the
   keystore file only has signing information. But the app ID, verison
   name, and version code all do need to be potentially modified in the
   example to get it up and running. They're not inherently sensitive
   like the signing information is but it probably makes sense to keep
   them out of source control for the plugin repo too.
2. Fixed the MethodChannel argument naming for some of the new methods.
3. Added a missing `BillingResponse` code.
4. Changed the `BillingClient#_callbacks` to be a map of lists instead
   of a list of maps. The OnPurchasesUpdated() listener is a singleton
   and we never really have a good opportunity to pass down a `handle`.
   It makes more sense to me to store these by name. Also deleted the
   `remove` code since it would cause `handle` to be off for future
   entries.
5. Fixed a concurrency issue on Android in the example app, and tweaked
   the UI slightly.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants