Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] The FloatingActionButton requires an icon #1293

Merged
merged 1 commit into from
Feb 28, 2019
Merged

[google_maps_flutter] The FloatingActionButton requires an icon #1293

merged 1 commit into from
Feb 28, 2019

Conversation

sam-toon
Copy link
Contributor

The sample code doesn't work. It needs an icon specified for the FloatingActionButton.

@sam-toon sam-toon requested a review from amirh as a code owner February 28, 2019 10:26
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sam-toon
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@sam-toon sam-toon changed the title The FloatingActionButton requires an icon [google_maps_flutter] The FloatingActionButton requires an icon Feb 28, 2019
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!
I was working off master where icon is not required anymore (flutter/flutter#27711). But yeah we should make sure this works with stable.

@amirh amirh merged commit 29bc80d into flutter:master Feb 28, 2019
romaluca pushed a commit to romaluca/plugins that referenced this pull request Mar 6, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* delete all example/android/app/gradle.properties files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants