Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update all pubspecs to work with the latest version of pub and Flutter #2382

Merged
merged 5 commits into from
Dec 10, 2019

Conversation

amirh
Copy link
Contributor

@amirh amirh commented Dec 9, 2019

Description

  • Migrated all plugins to the new plugin platforms manifest
  • Removed author: and authors: fields from all pubspecs as the fields are deprecated, moved author names from various plugins to the repository's AUTHORS file.

Copy link
Contributor

@ened ened left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good except one, from a single glimpse

@@ -1,3 +1,7 @@
## 0.3.18+1

* Remove the deprecated `author:` field from pubspec.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version here doesn't match the pubspec.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I just realized a version bump was missing on #2295

@amirh amirh changed the title Remove deprecated author: field from all pubspecs [WIP] Remove deprecated author: field from all pubspecs Dec 9, 2019
@amirh amirh changed the title [WIP] Remove deprecated author: field from all pubspecs Remove deprecated author: field from all pubspecs Dec 9, 2019
@amirh amirh changed the title Remove deprecated author: field from all pubspecs Update all pubspecs to work with the latest version of pub and Flutter Dec 9, 2019
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


## 0.6.2+2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that an extra line has been removed here.

@@ -1,5 +1,9 @@
## 0.6.2+2
## 0.6.2+3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an extra line for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll follow-up in a separate PR, I want to avoid running all presubmits for all plugins just for this 😄

@amirh
Copy link
Contributor Author

amirh commented Dec 10, 2019

Presubmits are timing out 😞
I'm landing this PR and going to monitor post-submits before publishing any of the plugins.

cc @collinjackson

@amirh amirh merged commit fd5832b into flutter:master Dec 10, 2019
@amirh amirh deleted the remove_author branch December 10, 2019 00:48
eugenejeonme added a commit to COMANDKEYINC/flutter_plugins that referenced this pull request Dec 11, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
flutter#2382)

* Migrated all plugins to the new [plugin platforms manifest](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin-platforms)
* Removed `author:` and `authors:` fields from all pubspecs as the fields are deprecated, moved author names from various plugins to the repository's AUTHORS file.
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
flutter#2382)

* Migrated all plugins to the new [plugin platforms manifest](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin-platforms)
* Removed `author:` and `authors:` fields from all pubspecs as the fields are deprecated, moved author names from various plugins to the repository's AUTHORS file.
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
flutter#2382)

* Migrated all plugins to the new [plugin platforms manifest](https://flutter.dev/docs/development/packages-and-plugins/developing-packages#plugin-platforms)
* Removed `author:` and `authors:` fields from all pubspecs as the fields are deprecated, moved author names from various plugins to the repository's AUTHORS file.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants