This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[shared_preferences] fix typo in readme #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog and bump the patch version so we can publish the fixed readme to pub. |
otopba
approved these changes
Jan 19, 2020
amirh
reviewed
Jan 21, 2020
| @@ -2,7 +2,7 @@ name: shared_preferences | |||
| description: Flutter plugin for reading and writing simple key-value pairs. | |||
| Wraps NSUserDefaults on iOS and SharedPreferences on Android. | |||
| homepage: https://github.com/flutter/plugins/tree/master/packages/shared_preferences/shared_preferences | |||
| version: 0.5.6 | |||
| version: 0.5.7 | |||
There was a problem hiding this comment.
Bump the patch version as there is no new feature in this change (this should be 0.5.6+1)
amirh
suggested changes
Jan 21, 2020
otopba
approved these changes
Jan 22, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a typo in the main readme file. I fixed it.
Not sure if I should update version and changelog, as this is not code related.
Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?