This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Rename FlutterRunner and make launch deterministic when running other tests. #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flake is unrelated (flutter/flutter#51074), I'll tackle that next |
collinjackson
changed the title
emerssso
pushed a commit
to emerssso/plugins
that referenced
this pull request
Mar 11, 2020
…utter#2584) * Make FlutterRunner launch deterministic when running other tests. * Switch to using FlutterTestRunner
EdwinRomelta
pushed a commit
to EdwinRomelta/plugins
that referenced
this pull request
Jun 11, 2020
…utter#2584) * Make FlutterRunner launch deterministic when running other tests. * Switch to using FlutterTestRunner
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
…utter#2584) * Make FlutterRunner launch deterministic when running other tests. * Switch to using FlutterTestRunner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a flake where
FlutterRunnerdidn't always launch properly.Instead we are opting out of the Android test rule's auto-launch and having the runner do it manually.
Also renamed
FlutterRunnertoFlutterTestRunnerto avoid conflict with Fuchsia.