[video_player_platform_interface] Playback speed #3032
[video_player_platform_interface] Playback speed #3032
Conversation
9217602
to
cebe618
Compare
a068b6d
to
705ae77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this after CI passes.
@ditman Great 👍 I will follow up with the web PR (after the platform interface has been published). |
Will publish after CI passes on |
@creativecreatorormaybenot published v2.2.0. |
This seems to have caused breakage in Checking project video_player...
error - Classes can only extend other classes at test/video_player_test.dart:591:39 - (extends_non_class)
error - The method 'VideoPlayerApiTestSetup' isn't defined for the type 'FakeVideoPlayerPlatform' at test/video_player_test.dart:593:5 - (undefined_method)
info - The method doesn't override an inherited method at test/video_player_test.dart:605:18 - (override_on_non_overriding_member) |
@ditman I realized this in #3081 (comment) - really a dumb mistake by me because I did not consider the Is the way I fixed it in that PR fine or should I create an extra PR just for fixing the tree? |
@creativecreatorormaybenot can you please separate the fix to a small PR, so we can fix the tree for the next PRs that we have to merge? |
@ditman One second - IDE crashed 😄 |
Part
Part 1/3 of #3031.
This is the
video_player_platform_interface
part of that PR.Checklist, full code, et al. can be found in the linked PR.