This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[video_player_web] Playback speed #3081
Merged
ditman
merged 6 commits into
flutter:master
from
simpleclub-extended:video-player-playback-speed-web
Sep 26, 2020
Merged
[video_player_web] Playback speed #3081
ditman
merged 6 commits into
flutter:master
from
simpleclub-extended:video-player-playback-speed-web
Sep 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecreatorormaybenot
requested review from
cyanglaz and
iskakaushik
as code owners
September 25, 2020 22:12
12 tasks
@@ -29,5 +29,5 @@ dev_dependencies: | |||
pedantic: ^1.8.0 | |||
|
|||
environment: | |||
sdk: ">=2.1.0 <3.0.0" | |||
sdk: ">=2.8.0 <3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am changing this here just to be consistent with the platform interface (the platform interface requires it because of pigeon v0.1.7
, which annotates it on a file in preparation of null safety).
This was referenced Sep 25, 2020
ditman
approved these changes
Sep 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
jorgefspereira
pushed a commit
to jorgefspereira/plugins_flutter
that referenced
this pull request
Oct 10, 2020
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part
Part 2/3 of #3031.
This is the
video_player_web
part of that PR.Checklist, full code, et al. can be found in the linked PR.