[image_picker] changed ExifInterface to AndroidX version, including d… #3036

anniek-valk · 2020-09-16T07:47:33Z

…ocumentation and an added dependency

Description

Changed the library of the Android class ExifInterface to the library of AndroidX. This because this version works on more image file formats, so there's better user experience. I changed the documentation to include the new supported formats.

Related Issues

Issue 64999

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

googlebot · 2020-09-16T07:47:37Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-09-16T10:00:33Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

We need to bump the version for the interface plugin as well.

cyanglaz · 2020-09-16T18:00:51Z

packages/image_picker/image_picker/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.8
+
+* Updated the ExifInterface to the AndroidX version to support more file formats


nits:

Suggested change

* Updated the ExifInterface to the AndroidX version to support more file formats

* Updated the ExifInterface to the AndroidX version to support more file formats.

Done, added the period.

cyanglaz · 2020-09-16T18:03:28Z

packages/image_picker/image_picker/pubspec.yaml

@@ -2,7 +2,7 @@ name: image_picker
 description: Flutter plugin for selecting images from the Android and iOS image
  library, and taking new pictures with the camera.
 homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
-version: 0.6.7+7
+version: 0.6.8


Since there is no public API syntax change, we can just update the patch version. So: 0.6.7+8
https://dart.dev/tools/pub/versioning#semantic-versions

Changed the version number.

anniek-valk · 2020-09-17T07:40:11Z

We need to bump the version for the interface plugin as well.

Totally forgot to do that, fixed it now.

cyanglaz · 2020-09-17T20:40:45Z

#3037 is merged, please resolve the conflicts.

cpboyd · 2020-09-18T17:09:42Z

packages/image_picker/image_picker/android/build.gradle

@@ -37,5 +37,6 @@ android {
    dependencies {
        implementation 'androidx.core:core:1.0.2'
        implementation 'androidx.annotation:annotation:1.0.0'
+        implementation 'androidx.exifinterface:exifinterface:1.1.0'


ExifInterface 1.3.0 was just released: https://developer.android.com/jetpack/androidx/releases/exifinterface

…ocumentation and an added dependency

googlebot · 2020-09-18T20:12:39Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mvanbeusekom · 2020-09-18T20:14:38Z

@googlebot I consent.

googlebot · 2020-09-18T20:14:43Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

LGTM!

flutter#3036)

googlebot added the cla: no label Sep 16, 2020

googlebot added cla: yes and removed cla: no labels Sep 16, 2020

anniek-valk closed this Sep 16, 2020

anniek-valk reopened this Sep 16, 2020

cyanglaz reviewed Sep 16, 2020

View reviewed changes

cpboyd reviewed Sep 18, 2020

View reviewed changes

anniek-valk and others added 2 commits September 18, 2020 21:51

[image_picker] changed ExifInterface to AndroidX version, including d…

724fc6c

…ocumentation and an added dependency

Style fix (deleted empty lines)

430c93c

mvanbeusekom force-pushed the issue-64999 branch from beb0bb6 to 430c93c Compare September 18, 2020 19:56

Update to latest version of the androidx.exifinterface library

5cb8253

googlebot added cla: no and removed cla: yes labels Sep 18, 2020

googlebot added cla: yes and removed cla: no labels Sep 18, 2020

cyanglaz approved these changes Sep 18, 2020

View reviewed changes

cyanglaz merged commit b5b88f6 into flutter:master Sep 18, 2020

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 1, 2020

[image_picker] changed ExifInterface to AndroidX version, including d… (

596ba7e

flutter#3036)

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[image_picker] changed ExifInterface to AndroidX version, including d… (

3447621

flutter#3036)

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[image_picker] changed ExifInterface to AndroidX version, including d… (

c8e60ec

flutter#3036)

mvanbeusekom deleted the issue-64999 branch September 21, 2021 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] changed ExifInterface to AndroidX version, including d… #3036

[image_picker] changed ExifInterface to AndroidX version, including d… #3036

anniek-valk commented Sep 16, 2020

googlebot commented Sep 16, 2020

googlebot commented Sep 16, 2020

cyanglaz left a comment

cyanglaz Sep 16, 2020

anniek-valk Sep 17, 2020

cyanglaz Sep 16, 2020

anniek-valk Sep 17, 2020

anniek-valk commented Sep 17, 2020

cyanglaz commented Sep 17, 2020

cpboyd Sep 18, 2020

googlebot commented Sep 18, 2020

mvanbeusekom commented Sep 18, 2020

googlebot commented Sep 18, 2020

cyanglaz left a comment

		@@ -1,3 +1,7 @@
		## 0.6.8

		* Updated the ExifInterface to the AndroidX version to support more file formats

[image_picker] changed ExifInterface to AndroidX version, including d… #3036

[image_picker] changed ExifInterface to AndroidX version, including d… #3036

Conversation

anniek-valk commented Sep 16, 2020

Description

Related Issues

Checklist

Breaking Change

googlebot commented Sep 16, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Sep 16, 2020

cyanglaz left a comment

Choose a reason for hiding this comment

cyanglaz Sep 16, 2020

Choose a reason for hiding this comment

anniek-valk Sep 17, 2020

Choose a reason for hiding this comment

cyanglaz Sep 16, 2020

Choose a reason for hiding this comment

anniek-valk Sep 17, 2020

Choose a reason for hiding this comment

anniek-valk commented Sep 17, 2020

cyanglaz commented Sep 17, 2020

cpboyd Sep 18, 2020

Choose a reason for hiding this comment

googlebot commented Sep 18, 2020

mvanbeusekom commented Sep 18, 2020

googlebot commented Sep 18, 2020

cyanglaz left a comment

Choose a reason for hiding this comment