[image_picker] Updated docs getImage() about preference rear front not working on Android #3037

anniek-valk · 2020-09-16T10:46:54Z

Description

Updated the documentation of getImage() in image_picker.dart and image_picker_platform.dart about Android's disability to preference front/rear camera, because this wasn't specified and caused confusion for people wondering why it didn't work.

Related Issues

Issue 55644

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

…oid's impossibility to specify camera

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

googlebot · 2020-09-16T10:46:59Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

mvanbeusekom · 2020-09-16T11:32:48Z

@googlebot I fixed it.

googlebot · 2020-09-16T11:32:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

LGTM % the versioning and some nits on the documentation.

cyanglaz · 2020-09-16T17:50:52Z

packages/image_picker/image_picker/pubspec.yaml

@@ -2,7 +2,7 @@ name: image_picker
 description: Flutter plugin for selecting images from the Android and iOS image
  library, and taking new pictures with the camera.
 homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
-version: 0.6.7+7
+version: 0.6.8


Since it is just a documentation update, we should only update the patch version, so 0.6.7+8
https://dart.dev/tools/pub/versioning#semantic-versions

Changed version number to 0.6.7+8 (missed the part which explained the semantic versioning prior version 1.0.0).

cyanglaz · 2020-09-16T17:55:08Z

packages/image_picker/image_picker/lib/image_picker.dart

@@ -87,7 +87,8 @@ class ImagePicker {
  ///
  /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera].
  /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device.
-  /// Defaults to [CameraDevice.rear].
+  /// Defaults to [CameraDevice.rear]. Since Android has no documented parameter for an intent to specify if the front or rear camera should be opened, this


Maybe the Since Android.. part should be a new line. Ditto below.

Done, I updated the documentation to (also in the image_picker_platform_interface):

/// Defaults to [CameraDevice.rear]. /// /// Note that Android has no documented parameter for an intent to specify if /// the front or rear camera should be opened, this function is not guaranteed /// to work on an Android device.

cyanglaz

We need to bump the version for the platform_interface plugin as well

cyanglaz · 2020-09-16T18:00:40Z

packages/image_picker/image_picker/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.6.8
+
+* Update documentation of getImage() about Android's disability to preference front/rear camera


nits:

Suggested change

* Update documentation of getImage() about Android's disability to preference front/rear camera

* Update documentation of getImage() about Android's disability to preference front/rear camera.

Added the extra period.

googlebot · 2020-09-16T21:53:47Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

cyanglaz

LGTM! CI seems unhappy with formatting.

cyanglaz · 2020-09-17T02:33:24Z

...picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart

@@ -132,7 +132,11 @@ abstract class ImagePickerPlatform extends PlatformInterface {
  ///
  /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera].
  /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device.
-  /// Defaults to [CameraDevice.rear].
+  /// Defaults to [CameraDevice.rear]. 
+  /// 


Actually, I think you were right. It was related to the comment above. Whatever you did was correct. My mistake :) Can we revert this change? Sorry for the confusion.
Same above.

No problem, will revert back

anniek-valk · 2020-09-17T07:21:58Z

@googlebot I consent.

mvanbeusekom · 2020-09-17T07:29:39Z

@googlebot I consent.

googlebot · 2020-09-17T07:29:47Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cyanglaz

LGTM!

…t working on Android (flutter#3037)

anniek-valk and others added 4 commits September 11, 2020 15:08

Updated documentation of getImage() to include information about Andr…

c662d4c

…oid's impossibility to specify camera

Update pubspec.yaml en CHANGELOG.md version

4adfbcb

Update packages/image_picker/image_picker/pubspec.yaml version

9be0757

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

Update packages/image_picker/image_picker/CHANGELOG.md version

b63982d

Co-authored-by: Maurits van Beusekom <maurits@vnbskm.nl>

googlebot added the cla: no label Sep 16, 2020

googlebot added cla: yes and removed cla: no labels Sep 16, 2020

cyanglaz reviewed Sep 16, 2020

View reviewed changes

Process feedback on pull-request

945fa26

googlebot added cla: no and removed cla: yes labels Sep 16, 2020

cyanglaz approved these changes Sep 17, 2020

View reviewed changes

mvanbeusekom added 2 commits September 17, 2020 08:02

Fix formatting issues

5ca7968

Revert comment on new line

b3a6b19

googlebot added cla: yes and removed cla: no labels Sep 17, 2020

cyanglaz approved these changes Sep 17, 2020

View reviewed changes

cyanglaz merged commit d16fd7a into flutter:master Sep 17, 2020

cyanglaz mentioned this pull request Sep 17, 2020

[image_picker] changed ExifInterface to AndroidX version, including d… #3036

Merged

13 tasks

danielroek pushed a commit to Baseflow/flutter-plugins that referenced this pull request Sep 18, 2020

[image_picker] Updated docs getImage() about preference rear front no…

7ceba00

…t working on Android (flutter#3037)

jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020

[image_picker] Updated docs getImage() about preference rear front no…

7319017

…t working on Android (flutter#3037)

FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020

[image_picker] Updated docs getImage() about preference rear front no…

e599121

…t working on Android (flutter#3037)

mvanbeusekom deleted the issue-55644 branch September 21, 2021 09:31

darshankawar mentioned this pull request Jan 5, 2022

[ImagePicker] preferredCameraDevice: CameraDevice.rear does not work flutter/flutter#96114

Closed

danagbemava-nc mentioned this pull request Feb 7, 2022

Camera opens in Selfie mode flutter/flutter#97937

Closed

darshankawar mentioned this pull request May 19, 2022

[image_picker: ^0.8.5+3][Android][Camera] -> request to open with default front camera but it open camera with default rear camera option. flutter/flutter#104162

Closed

danagbemava-nc mentioned this pull request Mar 15, 2023

CameraDevice.Rear not working flutter/flutter#122672

Closed

huycozy mentioned this pull request Jun 12, 2023

Preferred Camera Device is not working on Android flutter/flutter#128515

Closed

2 tasks

danagbemava-nc mentioned this pull request Jun 30, 2023

Image Picker CameraDevice.rear does not work flutter/flutter#129770

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] Updated docs getImage() about preference rear front not working on Android #3037

[image_picker] Updated docs getImage() about preference rear front not working on Android #3037

anniek-valk commented Sep 16, 2020

googlebot commented Sep 16, 2020

mvanbeusekom commented Sep 16, 2020

googlebot commented Sep 16, 2020

cyanglaz left a comment

cyanglaz Sep 16, 2020

mvanbeusekom Sep 16, 2020

cyanglaz Sep 16, 2020

mvanbeusekom Sep 16, 2020

cyanglaz left a comment

cyanglaz Sep 16, 2020

mvanbeusekom Sep 16, 2020

googlebot commented Sep 16, 2020

cyanglaz left a comment

cyanglaz Sep 17, 2020

mvanbeusekom Sep 17, 2020

anniek-valk commented Sep 17, 2020

mvanbeusekom commented Sep 17, 2020

googlebot commented Sep 17, 2020

cyanglaz left a comment

		@@ -1,3 +1,7 @@
		## 0.6.8

		* Update documentation of getImage() about Android's disability to preference front/rear camera

[image_picker] Updated docs getImage() about preference rear front not working on Android #3037

[image_picker] Updated docs getImage() about preference rear front not working on Android #3037

Conversation

anniek-valk commented Sep 16, 2020

Description

Related Issues

Checklist

Breaking Change

googlebot commented Sep 16, 2020

mvanbeusekom commented Sep 16, 2020

googlebot commented Sep 16, 2020

cyanglaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Sep 16, 2020

cyanglaz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anniek-valk commented Sep 17, 2020

mvanbeusekom commented Sep 17, 2020

googlebot commented Sep 17, 2020

cyanglaz left a comment

Choose a reason for hiding this comment