Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[plugin_platform_interface] Migrate to null safety #3115

Merged
merged 12 commits into from Oct 9, 2020

Conversation

blasten
Copy link

@blasten blasten commented Oct 6, 2020

Description

Migration to null safety.

Companion PR: https://github.com/flutter/plugin_tools/pull/110

Related Issues

flutter/flutter#66395

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@blasten blasten requested review from amirh and cyanglaz October 6, 2020 02:23
@blasten
Copy link
Author

blasten commented Oct 6, 2020

checks should be green once flutter/plugin_tools#110 is merged, and the package published.

@@ -1,5 +1,7 @@
include: package:pedantic/analysis_options.1.8.0.yaml
analyzer:
enable-experiment:
- non-nullable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this enable the analyzer for all plugins?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@blasten blasten force-pushed the plugin_platform_interface_nnbd branch from e68214d to bc9a917 Compare October 7, 2020 19:58
@blasten blasten force-pushed the plugin_platform_interface_nnbd branch from bc9a917 to c188391 Compare October 7, 2020 22:46
Emmanuel Garcia added 2 commits October 7, 2020 17:21
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten force-pushed the plugin_platform_interface_nnbd branch from c03d64b to ce74341 Compare October 9, 2020 18:10
@blasten blasten merged commit e5e0c3b into flutter:nnbd Oct 9, 2020
@blasten blasten deleted the plugin_platform_interface_nnbd branch October 9, 2020 19:01
mvanbeusekom pushed a commit to Baseflow/flutter-plugins that referenced this pull request Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants