This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[plugin_platform_interface] Migrate to null safety #3115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checks should be green once flutter/plugin_tools#110 is merged, and the package published. |
cyanglaz
reviewed
Oct 6, 2020
@@ -1,5 +1,7 @@ | |||
include: package:pedantic/analysis_options.1.8.0.yaml | |||
analyzer: | |||
enable-experiment: | |||
- non-nullable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this enable the analyzer for all plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
blasten
force-pushed
the
plugin_platform_interface_nnbd
branch
from
October 7, 2020 19:58
e68214d
to
bc9a917
Compare
blasten
force-pushed
the
plugin_platform_interface_nnbd
branch
from
October 7, 2020 22:46
bc9a917
to
c188391
Compare
blasten
commented
Oct 8, 2020
blasten
force-pushed
the
plugin_platform_interface_nnbd
branch
from
October 8, 2020 00:53
61ff95e
to
e1f7ce3
Compare
amirh
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/plugin_platform_interface/test/plugin_platform_interface_test.dart
Outdated
Show resolved
Hide resolved
blasten
force-pushed
the
plugin_platform_interface_nnbd
branch
from
October 9, 2020 18:10
c03d64b
to
ce74341
Compare
mvanbeusekom
pushed a commit
to Baseflow/flutter-plugins
that referenced
this pull request
Oct 12, 2020
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration to null safety.
Companion PR: https://github.com/flutter/plugin_tools/pull/110
Related Issues
flutter/flutter#66395
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?