Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Flutter Gallery test to NNBD #66395

Closed
blasten opened this issue Sep 22, 2020 · 5 comments · Fixed by #69048
Closed

Migrate Flutter Gallery test to NNBD #66395

blasten opened this issue Sep 22, 2020 · 5 comments · Fixed by #69048
Labels
a: null-safety Support for the Dart's team new null safety feature a: tests "flutter test", flutter_test, or one of our tests package flutter/packages repository. See also p: labels.

Comments

@blasten
Copy link

blasten commented Sep 22, 2020

Tracks the migration to NNBD, which includes all the dependencies.

Dependencies

Dependency Current version Owner Issue/PR
connectivity 0.4.9+2 Flutter Ecosystem
connectivity_for_web 0.3.1+2 Flutter Ecosystem
connectivity_macos 0.1.0+4 Flutter Ecosystem
connectivity_platform_interface 1.0.6 Flutter Ecosystem
device_info 0.4.2+7 Flutter Ecosystem
device_info_platform_interface 1.0.1 Flutter Ecosystem
plugin_platform_interface 1.0.2 Flutter Ecosystem flutter/plugins#3115
url_launcher 5.5.3 Flutter Ecosystem
url_launcher_linux 0.0.1+1 Flutter Ecosystem
url_launcher_macos 0.0.1+7 Flutter Ecosystem
url_launcher_platform_interface 1.0.8 Flutter Ecosystem
url_launcher_web 1.3+2 Flutter Ecosystem
video_player 0.10.6 @blasten flutter/plugins#3045
video_player_platform_interface 1.0.5 @blasten flutter/plugins#3045
video_player_web 0.1.2+3 Flutter Ecosystem
flutter Flutter Framework dart-lang/sdk#40146
flutter_web_plugins @ditman #69843
intl 0.16.1 Dart SDK
pub_semver 1.4.4 Dart SDK
platform_detect 1.4.0 @ditman #66385
scoped_model 1.0.1 3P
pigeon 0.1.10 @gaaclarke #59118

/cc @pcsosinski

@blasten blasten added a: tests "flutter test", flutter_test, or one of our tests plugin a: null-safety Support for the Dart's team new null safety feature labels Sep 22, 2020
@blasten blasten changed the title Migrate Flutter Gallery to NNBD Migrate Flutter Gallery test to NNBD Sep 22, 2020
@ditman
Copy link
Member

ditman commented Sep 22, 2020

I'll find out if anybody's working on flutter_web_plugins, and take it next if nobody is.

(This one depends on flutter/foundation.dart and flutter/servics.dart being migrated in a couple of places)

@stuartmorgan
Copy link
Contributor

stuartmorgan commented Sep 24, 2020

url_launcher_windows will be on this list as of a couple of days ago.

@stuartmorgan
Copy link
Contributor

I just checked all the desktop plugins (url_launcher_windows/macos/linux, connectivity_macos) and they are all using the traditional model of implementing a shared platform channel interface, so none of them have any Dart code outside of the example/ (which presumably won't need to be migrated for Gallery)

@kevmoo
Copy link
Contributor

kevmoo commented Oct 6, 2020

As discussed elsewhere, the dependency on scoped_model should likely be dropped.

  • It's a 1-file package. (Should be easy to replace/inline)
  • It hasn't been touched in ~2 years

CC @pcsosinski

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: null-safety Support for the Dart's team new null safety feature a: tests "flutter test", flutter_test, or one of our tests package flutter/packages repository. See also p: labels.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants