Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for wifi_info_flutter plugin and platform interface #3129

Merged
merged 11 commits into from Oct 9, 2020

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 8, 2020

Description

This PR is from the generated code when running the lines below. Only small changes were made to get tests passing.

flutter create --platforms=android,ios -t plugin --org="io.flutter.plugins" -a java -i objc --project-name=wifi_info_flutter .
flutter create -t package --project-name=wifi_info_flutter_platform_interface .

Beginning a larger effort to separate wifi related methods from the connectivity plugin. See flutter/flutter#40418

Related Issues

flutter/flutter#40418

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Oct 8, 2020
@@ -0,0 +1,3 @@
## [0.0.1] - TODO: Add release date.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@@ -0,0 +1 @@
TODO: Add your license here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@@ -0,0 +1,14 @@
# wifi_info_flutter_platform_interface

A new Flutter package project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

library wifi_info_flutter_platform_interface;

/// A Calculator.
class Calculator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@@ -0,0 +1,53 @@
name: wifi_info_flutter_platform_interface
description: A new Flutter package project.
version: 0.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start the platform interface at 1 as we don't want major bumps

# The following section is specific to Flutter.
flutter:

# To add assets to your package, add an assets section, like this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the boilerplate

@@ -0,0 +1,13 @@
import 'package:flutter_test/flutter_test.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@bparrishMines
Copy link
Contributor Author

@amirh This PR was only supposed to be code generated from flutter create and small changes to get tests passing. Ideally, this makes it easier to review and the following PRs will have non-generated code.

@amirh
Copy link
Contributor

amirh commented Oct 9, 2020

Ok! let's just add the license files before submitting.

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just add license files before submitting

@bparrishMines bparrishMines changed the title [wifi_info_flutter] Initial commit for wifi_info_flutter plugin and platform interface [wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for wifi_info_flutter plugin and platform interface Oct 9, 2020
@bparrishMines bparrishMines merged commit a346783 into flutter:master Oct 9, 2020
@bparrishMines bparrishMines deleted the wifi_initial branch October 9, 2020 20:12
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
…mmit for `wifi_info_flutter` plugin and platform interface (flutter#3129)
blasten pushed a commit that referenced this pull request Oct 15, 2020
* Android Code Inspection and Clean up (#3117)

* [in_app_purchase] Android Code Inspection and Clean up (#3120)

* Android Code Inspection and Clean up

* Format

* [video_player] Fix SSLProtocolException for low API version (#3122)

* [camera] Set audio encoding bitrate when recording video (#3124)

Fixes flutter/flutter#38787

* Fix links in package example readmes (#3130)

http://flutter.io/ -> https://flutter.dev/

* [integration_test] Add watchPerformance (#3116)

* add watchPerformance

* [wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for `wifi_info_flutter` plugin and platform interface (#3129)

* [video_player] fix Timer Leak (#3119)

* [in_app_purchase] Add example test target to Podfile, add OCMock dependency (#3145)

* Add linux directory to examples (#3064)

When Linux support was added to these plugins, the app template wasn't
yet stabilized, so was not checked in. Now that it is stable, this adds
them so that the plugin_tools workaround that created them on each run
can be removed.

Other than CHANGELOG.md updates and updating the verison in
pubspec.yaml, this is purely the result of running 'flutter create .' in
the example/ folders and adding the resulting linux/ directories.

* [wifi_info_flutter_plugin_interface] implement wifi platform interface (#3134)

* [share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. (#3152)

* Android API 29 & 30

* Update Version

* Update android sdk version to 29 for all mobile plugins. (#3042)

* [google_sign_in]  fix merge error in CHANGELOG (#3153)

Co-authored-by: Hamdi Kahloun <32666446+hamdikahloun@users.noreply.github.com>
Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com>
Co-authored-by: Ming Lyu (CareF) <minglyu@google.com>
Co-authored-by: Maurice Parrish <bmparr@google.com>
Co-authored-by: creativecreatorormaybenot <creativecreatorormaybenot@gmail.com>
Co-authored-by: Jenn Magder <magder@google.com>
Co-authored-by: stuartmorgan <stuartmorgan@google.com>
Co-authored-by: Chris Yang <ychris@google.com>
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
…mmit for `wifi_info_flutter` plugin and platform interface (flutter#3129)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants