This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[in_app_purchase] Add example test target to Podfile, add OCMock dependency #3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyanglaz
approved these changes
Oct 12, 2020
jmagman
commented
Oct 12, 2020
Comment on lines
+34
to
+37
| inherit! :search_paths | ||
|
|
||
| # Matches in_app_purchase test_spec dependency. | ||
| pod 'OCMock','3.5' |
There was a problem hiding this comment.
This is the important bit.
blasten
pushed a commit
that referenced
this pull request
Oct 15, 2020
* Android Code Inspection and Clean up (#3117) * [in_app_purchase] Android Code Inspection and Clean up (#3120) * Android Code Inspection and Clean up * Format * [video_player] Fix SSLProtocolException for low API version (#3122) * [camera] Set audio encoding bitrate when recording video (#3124) Fixes flutter/flutter#38787 * Fix links in package example readmes (#3130) http://flutter.io/ -> https://flutter.dev/ * [integration_test] Add watchPerformance (#3116) * add watchPerformance * [wifi_info_flutter] [wifi_info_flutter_platform_interface] Initial commit for `wifi_info_flutter` plugin and platform interface (#3129) * [video_player] fix Timer Leak (#3119) * [in_app_purchase] Add example test target to Podfile, add OCMock dependency (#3145) * Add linux directory to examples (#3064) When Linux support was added to these plugins, the app template wasn't yet stabilized, so was not checked in. Now that it is stable, this adds them so that the plugin_tools workaround that created them on each run can be removed. Other than CHANGELOG.md updates and updating the verison in pubspec.yaml, this is purely the result of running 'flutter create .' in the example/ folders and adding the resulting linux/ directories. * [wifi_info_flutter_plugin_interface] implement wifi platform interface (#3134) * [share] Replace deprecated Environment.getExternalStorageDirectory() call on Android. (#3152) * Android API 29 & 30 * Update Version * Update android sdk version to 29 for all mobile plugins. (#3042) * [google_sign_in] fix merge error in CHANGELOG (#3153) Co-authored-by: Hamdi Kahloun <32666446+hamdikahloun@users.noreply.github.com> Co-authored-by: Maurits van Beusekom <maurits@baseflow.com> Co-authored-by: Kevin Moore <kevmoo@users.noreply.github.com> Co-authored-by: Ming Lyu (CareF) <minglyu@google.com> Co-authored-by: Maurice Parrish <bmparr@google.com> Co-authored-by: creativecreatorormaybenot <creativecreatorormaybenot@gmail.com> Co-authored-by: Jenn Magder <magder@google.com> Co-authored-by: stuartmorgan <stuartmorgan@google.com> Co-authored-by: Chris Yang <ychris@google.com>
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test target wasn't building in example app because it wasn't inheriting search paths from the Runner target (which allows the linker to find the plugin frameworks, plus Flutter framework). Also add OCMock dependency to match test_spec podspec.
Related Issues
Fixes flutter/flutter#67175
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change