Conversation
I'm confused why travis is failing with messages like these:
|
@mit-mit For package versions > 1.0.0, we shouldn't do +z Details in https://dart.dev/tools/pub/versioning#semantic-versions |
@cyanglaz yes, of course, I missed that; fixed now. But what about this one:
This PR didn't change that dep., and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the math in the +1s on >=1.0.0 versions.
packages/connectivity/connectivity_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/connectivity/connectivity_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/device_info/device_info_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/device_info/device_info_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/file_selector/file_selector_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
packages/wifi_info_flutter/wifi_info_flutter_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/wifi_info_flutter/wifi_info_flutter_platform_interface/pubspec.yaml
Outdated
Show resolved
Hide resolved
Sorry @ditman for my failing search skills, I missed so many of those |
…G.md Co-authored-by: David Iglesias <ditman@gmail.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: David Iglesias <ditman@gmail.com>
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@ditman looks like your GitHub account is using the wrong email account? |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: David Iglesias <ditman@gmail.com>
Co-authored-by: David Iglesias <ditman@gmail.com>
This comment has been minimized.
This comment has been minimized.
2 similar comments
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
…rface/CHANGELOG.md Co-authored-by: David Iglesias <ditman@gmail.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-authored-by: David Iglesias <ditman@gmail.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
This comment has been minimized.
This comment has been minimized.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
WTF thanks for letting me know, I'll get my personal address CLA'd real quick, let me boot up my personal laptop. |
@googlebot I fixed it. |
Abandoning in favor of a set of updated smaller PRs |
Description
Align plugins with new templates, removing unused upper constraint
Related Issues
flutter/flutter#68437