Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove upper constraints #3236

Closed
wants to merge 22 commits into from
Closed

Remove upper constraints #3236

wants to merge 22 commits into from

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Oct 30, 2020

Description

Align plugins with new templates, removing unused upper constraint

Related Issues

flutter/flutter#68437

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

@amirh @ditman this is the continuation of #3231

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

I'm confused why travis is failing with messages like these:

�[31mpackages/battery/battery/pubspec.yaml incorrectly updated version.
HEAD: 1.0.7+1, master: 1.0.7.
Allowed versions: {2.0.0: NextVersionType.BREAKING_MAJOR, 2.0.0-nullsafety: NextVersionType.MAJOR_NULLSAFETY_PRE_RELEASE, 1.1.0-nullsafety: NextVersionType.MINOR_NULLSAFETY_PRE_RELEASE, 1.1.0: NextVersionType.MINOR, 1.0.8: NextVersionType.PATCH}�[0m

@cyanglaz
Copy link
Contributor

@mit-mit For package versions > 1.0.0, we shouldn't do +z
So for battery/battery/pubspec.yaml, it should be 1.0.8 instead of 1.0.7+1

Details in https://dart.dev/tools/pub/versioning#semantic-versions

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

@cyanglaz yes, of course, I missed that; fixed now.

But what about this one:

Package validation found the following potential issue:
* Your dependency on "video_player_web" should have an upper bound. For example:
  
  dependencies:
    video_player_web: ^0.1.4
  
  Without an upper bound, you're promising to support all future versions of video_player_web.

This PR didn't change that dep., and ^0.1.4 does have an upper bound (<0.2.0).

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the math in the +1s on >=1.0.0 versions.

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

I did the math in the +1s on >=1.0.0 versions.

Sorry @ditman for my failing search skills, I missed so many of those

…G.md

Co-authored-by: David Iglesias <ditman@gmail.com>
@google-cla

This comment has been minimized.

@google-cla google-cla bot removed the cla: yes label Oct 30, 2020
Co-authored-by: David Iglesias <ditman@gmail.com>
@google-cla

This comment has been minimized.

3 similar comments
@google-cla

This comment has been minimized.

@google-cla

This comment has been minimized.

@google-cla
Copy link

google-cla bot commented Oct 30, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

@ditman looks like your GitHub account is using the wrong email account?

@google-cla

This comment has been minimized.

mit-mit and others added 2 commits October 31, 2020 15:18
Co-authored-by: David Iglesias <ditman@gmail.com>
Co-authored-by: David Iglesias <ditman@gmail.com>
@google-cla

This comment has been minimized.

2 similar comments
@google-cla
Copy link

google-cla bot commented Oct 31, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 31, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…rface/CHANGELOG.md

Co-authored-by: David Iglesias <ditman@gmail.com>
@google-cla

This comment has been minimized.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 31, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Iglesias <ditman@gmail.com>
@google-cla

This comment has been minimized.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 31, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla

This comment has been minimized.

@google-cla
Copy link

google-cla bot commented Oct 31, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ditman
Copy link
Member

ditman commented Nov 2, 2020

@ditman looks like your GitHub account is using the wrong email account?

WTF thanks for letting me know, I'll get my personal address CLA'd real quick, let me boot up my personal laptop.

@ditman
Copy link
Member

ditman commented Nov 2, 2020

@googlebot I fixed it.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 2, 2020
@mit-mit
Copy link
Member Author

mit-mit commented Dec 11, 2020

Abandoning in favor of a set of updated smaller PRs

@mit-mit mit-mit closed this Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants