Add Dart SDK constraint to example pubspecs that were missing them #3240
Conversation
zanderso
requested review from
bkonyi,
cyanglaz,
iskakaushik,
matthew-carroll and
mklim
as code owners
|
We should probably re-publish all these plugins (to make sure the pub.dev score won't get hit by analysis errors) so we need to bump the version numbers and add changelog entries. Side note: it is worrying that so many packages had this problem and were affected by flutter/flutter#69440 (comment), I'm wondering what's the status for all the existing packages in the wild (is it possible that we had a time range during which the plugin template didn't include these constraints?) |
I think @mit-mit would know about the template, and might have run the numbers for missing sdk (or at least flutter) constraints once? |
zanderso
force-pushed
the
add-missing-sdk-constraints
branch
from
9eb3289
to
d4ec008
Compare
Done |
|
|
||
| environment: | ||
| sdk: ">=2.1.0 <3.0.0" | ||
| flutter: ">=1.12.13+hotfix.5 <2.0.0" |
There was a problem hiding this comment.
For the Flutter SDK constraint, please add the lower constraint only. See #3236 and flutter/flutter#68437
There was a problem hiding this comment.
The goal of this PR is to get flutter/plugins CI green with tip-of-tree framework. Other cleanup work can happen in a subsequent PR.
There was a problem hiding this comment.
Why would we add a constraint in this PR, and then remove it again later? I don't understand the value in incurring additional debt. The flutter constraint does nothing wrt. getting CI green; you just need the Dart constraint for that.
There was a problem hiding this comment.
This PR is consistent with the rest of the repo. Fixing every pubspec in the repo is out of scope for this PR. Choosing the right time to do other cleanups is up to @amirh to decide.
zanderso
force-pushed
the
add-missing-sdk-constraints
branch
from
d4ec008
to
edb7513
Compare
|
@amirh the Cirrus presubmits are timing out. Do you know what's up with that? |
Seems to be flutter/flutter#69439 😞 |
|
This has been incorporated into #3239 which also works around the driver timeout. |
|
Closing in favor of #3239 |
If a pubspec.yaml for an example was missing a Dart SDK constraint, this PR copies the
environmentsection from thepubspec.yamlfile in the parent directory.